Code review comment for lp:~nik90/ubuntu-clock-app/13-next-alarm-bottomedge

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> Please try to name the tests as
> test_someActionOrComponentMustDoOrDisplaySomething.
>
> 227 + function test_bottomEdgeTitle() {
>
> In my opinion, that naming rule makes it clear that you have at least three
> tests there.
>
> test_bottomEdgeTitleMustDisplayActiveAlarm
>
> test_bottomEdgeTitleMustDisplayNoAlarm
>
> test_bottomEdgeTitleMustDisplayNextAlarm
>
> Spliting them will make the tests clearer and easier to maintain. You will
> also get better feedback when only one of the features is failing, because you
> will have one test per code path.

Wholeheartedly agree :-). Implemented in latest rev as per your comment.

« Back to merge proposal