Code review comment for lp:~nik90/reminders-app/basic-structure

Revision history for this message
David Planella (dpm) wrote :

Thanks Nekhelesh!

Just a couple of minor things:

1) $ qmlscene reminders-app.qml
file:///tmp/basic-structure/reminders-app.qml:39 Notes is not a type

It seems that the Notes component is not in the tree, perhaps you forgot to commit it?

2) I also noticed that you're using the "ui" folder to put the components in. In that case, it might be worth removing the "components" folder if it's unused.

review: Needs Fixing

« Back to merge proposal