Code review comment for lp:~nik90/podbird/migrate-to-download-manager
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
@Mike, There was a critical bug where Podbird on crashing would send the DownloadManager to misbehave. It turns out that when you send an empty url to DownloadManager, it crashes the app and also causes the internal SingleDownload{} objects to not be destroyed until you restart the udm service.
I added a safety check to ensure we never send an empty url to DownloadManager which puts the critical bug to rest. I will nonetheless report this bug upstream against udm since it should handle this better imo.