Code review comment for lp:~nik90/podbird/improve-podcast-page

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> I like the new style, a couple of issue found while testing:
>

Awesome. Glad to hear. I thought perhaps I changed it too much without asking you.

> With that reorganisation you'll need to move the SingleDownload into main or
> similar, otherwise it'll get destroyed when the user leaves that page.
>

Ah yes, I moved it to podbird.qml alongside ImageDownloader. Fixed in rev 18

> It looks like PNGs aren't getting scaled correctly (subscribe to
> http://s.libre.fm/podcast.rss for an example), probably best to set the
> sourceSize for images (more memory efficient too)
>

By setting the sourceSize explicitly it now works correctly both on the phone and on the emulator for different podcasts I tried. Rev 15, 17

> The author field in the search tab doesn't elide and overlaps the edge of the
> screen for long author names (e.g. try searching for "Science", and looking at
> the "Hidden Universe HD" entry)
>

Fixed in rev 14

> Once those are fixed it should be good to go :).

I also fixed an issue where the duration icon was shown despite the duration being not available.

« Back to merge proposal