Code review comment for lp:~nik90/music-app/album-code-refactor-and-fixes

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Let me know what your final decision is regarding the ubuntu shape. Personally I like the "medium" radius since it matches with other apps and also looks good. But I leave that entirely up to you. As for the refactor portion, I will have one final look at my changes.

It seems that one of the tests is failing due to my code refactor. I tried fixing the test, but I am terrible with python and wasn't able to fix. Do you mind looking at it while reviewing my code and proposing a fix? The failing test is music_app.tests.test_music.TestMainWindow.test_add_song_to_queue_from_albums_sheet(with mouse)

« Back to merge proposal