Merge lp:~nigelbabu/ubuntu/oneiric/redis/fix-ftbfs into lp:ubuntu/oneiric/redis

Proposed by Nigel Babu
Status: Merged
Merged at revision: 29
Proposed branch: lp:~nigelbabu/ubuntu/oneiric/redis/fix-ftbfs
Merge into: lp:ubuntu/oneiric/redis
Diff against target: 99 lines (+59/-1)
6 files modified
.pc/.quilt_patches (+1/-0)
.pc/.quilt_series (+1/-0)
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/fix-link-ordering (+48/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~nigelbabu/ubuntu/oneiric/redis/fix-ftbfs
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
Ubuntu branches Pending
Review via email: mp+62204@code.launchpad.net

Description of the change

Fixed the FTBFS

To post a comment you must log in.
30. By Nigel Babu

Fixed FTBFS (LP: #771061), updated changelog with bug number

31. By Nigel Babu

Moved the linking to the right on two lines

32. By Nigel Babu

Update maintainter

33. By Nigel Babu

Remove the change from the source to a patch file

34. By Nigel Babu

Added information about upstream and debian bug

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Looks good, thanks!

review: Approve
Revision history for this message
Jerry Seutter (jseutter) wrote :

Description is spelled Descrption in the diff.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file '.pc/.quilt_patches'
--- .pc/.quilt_patches 1970-01-01 00:00:00 +0000
+++ .pc/.quilt_patches 2011-05-26 18:45:21 +0000
@@ -0,0 +1,1 @@
1debian/patches
02
=== added file '.pc/.quilt_series'
--- .pc/.quilt_series 1970-01-01 00:00:00 +0000
+++ .pc/.quilt_series 2011-05-26 18:45:21 +0000
@@ -0,0 +1,1 @@
1series
02
=== modified file 'debian/changelog'
--- debian/changelog 2011-04-25 14:04:29 +0000
+++ debian/changelog 2011-05-26 18:45:21 +0000
@@ -1,3 +1,9 @@
1redis (2:2.2.5-1ubuntu1) oneiric; urgency=low
2
3 * Fixed FTBFS (LP: #771061)
4
5 -- Nigel Babu <nigelbabu@ubuntu.com> Wed, 25 May 2011 09:30:02 +0530
6
1redis (2:2.2.5-1) unstable; urgency=low7redis (2:2.2.5-1) unstable; urgency=low
28
3 * New upstream release.9 * New upstream release.
410
=== modified file 'debian/control'
--- debian/control 2011-02-24 19:39:43 +0000
+++ debian/control 2011-05-26 18:45:21 +0000
@@ -1,7 +1,8 @@
1Source: redis1Source: redis
2Section: database2Section: database
3Priority: optional3Priority: optional
4Maintainer: Chris Lamb <lamby@debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Chris Lamb <lamby@debian.org>
5Build-Depends: debhelper (>= 7.0.50)6Build-Depends: debhelper (>= 7.0.50)
6Standards-Version: 3.9.17Standards-Version: 3.9.1
7Homepage: http://redis.io/8Homepage: http://redis.io/
89
=== added file 'debian/patches/fix-link-ordering'
--- debian/patches/fix-link-ordering 1970-01-01 00:00:00 +0000
+++ debian/patches/fix-link-ordering 2011-05-26 18:45:21 +0000
@@ -0,0 +1,48 @@
1# Descrption: Fix the failed to build from source due to the --as-needed linking
2# Bug: http://code.google.com/p/redis/issues/detail?id=562
3# Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=628056
4# Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/redis/+bug/771061
5# Author: Nigel Babu <nigelbabu@ubuntu.com>
6--- a/src/Makefile
7+++ b/src/Makefile
8@@ -19,7 +19,7 @@
9 CCLINK+= -ltcmalloc
10 CFLAGS+= -DUSE_TCMALLOC
11 endif
12-CCOPT= $(CFLAGS) $(CCLINK) $(ARCH) $(PROF)
13+CCOPT= $(CFLAGS) $(ARCH) $(PROF)
14
15 PREFIX= /usr/local
16 INSTALL_BIN= $(PREFIX)/bin
17@@ -111,26 +111,26 @@
18 cd ../deps/linenoise && $(MAKE) ARCH="$(ARCH)"
19
20 redis-server: $(OBJ)
21- $(CC) -o $(PRGNAME) $(CCOPT) $(DEBUG) $(OBJ)
22+ $(CC) -o $(PRGNAME) $(CCOPT) $(DEBUG) $(OBJ) $(CCLINK)
23
24 redis-benchmark: dependencies $(BENCHOBJ)
25 cd ../deps/hiredis && $(MAKE) static
26- $(CC) -o $(BENCHPRGNAME) $(CCOPT) $(DEBUG) $(BENCHOBJ) ../deps/hiredis/libhiredis.a
27+ $(CC) -o $(BENCHPRGNAME) $(CCOPT) $(DEBUG) $(BENCHOBJ) ../deps/hiredis/libhiredis.a $(CCLINK)
28
29 redis-benchmark.o:
30 $(CC) -c $(CFLAGS) -I../deps/hiredis $(DEBUG) $(COMPILE_TIME) $<
31
32 redis-cli: dependencies $(CLIOBJ)
33- $(CC) -o $(CLIPRGNAME) $(CCOPT) $(DEBUG) $(CLIOBJ) ../deps/hiredis/libhiredis.a ../deps/linenoise/linenoise.o
34+ $(CC) -o $(CLIPRGNAME) $(CCOPT) $(DEBUG) $(CLIOBJ) ../deps/hiredis/libhiredis.a ../deps/linenoise/linenoise.o $(CCLINK)
35
36 redis-cli.o:
37 $(CC) -c $(CFLAGS) -I../deps/hiredis -I../deps/linenoise $(DEBUG) $(COMPILE_TIME) $<
38
39 redis-check-dump: $(CHECKDUMPOBJ)
40- $(CC) -o $(CHECKDUMPPRGNAME) $(CCOPT) $(DEBUG) $(CHECKDUMPOBJ)
41+ $(CC) -o $(CHECKDUMPPRGNAME) $(CCOPT) $(DEBUG) $(CHECKDUMPOBJ) $(CCLINK)
42
43 redis-check-aof: $(CHECKAOFOBJ)
44- $(CC) -o $(CHECKAOFPRGNAME) $(CCOPT) $(DEBUG) $(CHECKAOFOBJ)
45+ $(CC) -o $(CHECKAOFPRGNAME) $(CCOPT) $(DEBUG) $(CHECKAOFOBJ) $(CCLINK)
46
47 .c.o:
48 $(CC) -c $(CFLAGS) $(DEBUG) $(COMPILE_TIME) $<
049
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-04-25 14:04:29 +0000
+++ debian/patches/series 2011-05-26 18:45:21 +0000
@@ -1,1 +1,2 @@
1debian-changes-2:2.2.5-11debian-changes-2:2.2.5-1
2fix-link-ordering

Subscribers

People subscribed via source and target branches

to all changes: