Merge lp:~nigelbabu/ubuntu/oneiric/redis/fix-ftbfs into lp:ubuntu/oneiric/redis

Proposed by Nigel Babu
Status: Merged
Merged at revision: 29
Proposed branch: lp:~nigelbabu/ubuntu/oneiric/redis/fix-ftbfs
Merge into: lp:ubuntu/oneiric/redis
Diff against target: 99 lines (+59/-1)
6 files modified
.pc/.quilt_patches (+1/-0)
.pc/.quilt_series (+1/-0)
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/fix-link-ordering (+48/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~nigelbabu/ubuntu/oneiric/redis/fix-ftbfs
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
Ubuntu branches Pending
Review via email: mp+62204@code.launchpad.net

Description of the change

Fixed the FTBFS

To post a comment you must log in.
30. By Nigel Babu

Fixed FTBFS (LP: #771061), updated changelog with bug number

31. By Nigel Babu

Moved the linking to the right on two lines

32. By Nigel Babu

Update maintainter

33. By Nigel Babu

Remove the change from the source to a patch file

34. By Nigel Babu

Added information about upstream and debian bug

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Looks good, thanks!

review: Approve
Revision history for this message
Jerry Seutter (jseutter) wrote :

Description is spelled Descrption in the diff.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '.pc/.quilt_patches'
2--- .pc/.quilt_patches 1970-01-01 00:00:00 +0000
3+++ .pc/.quilt_patches 2011-05-26 18:45:21 +0000
4@@ -0,0 +1,1 @@
5+debian/patches
6
7=== added file '.pc/.quilt_series'
8--- .pc/.quilt_series 1970-01-01 00:00:00 +0000
9+++ .pc/.quilt_series 2011-05-26 18:45:21 +0000
10@@ -0,0 +1,1 @@
11+series
12
13=== modified file 'debian/changelog'
14--- debian/changelog 2011-04-25 14:04:29 +0000
15+++ debian/changelog 2011-05-26 18:45:21 +0000
16@@ -1,3 +1,9 @@
17+redis (2:2.2.5-1ubuntu1) oneiric; urgency=low
18+
19+ * Fixed FTBFS (LP: #771061)
20+
21+ -- Nigel Babu <nigelbabu@ubuntu.com> Wed, 25 May 2011 09:30:02 +0530
22+
23 redis (2:2.2.5-1) unstable; urgency=low
24
25 * New upstream release.
26
27=== modified file 'debian/control'
28--- debian/control 2011-02-24 19:39:43 +0000
29+++ debian/control 2011-05-26 18:45:21 +0000
30@@ -1,7 +1,8 @@
31 Source: redis
32 Section: database
33 Priority: optional
34-Maintainer: Chris Lamb <lamby@debian.org>
35+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
36+XSBC-Original-Maintainer: Chris Lamb <lamby@debian.org>
37 Build-Depends: debhelper (>= 7.0.50)
38 Standards-Version: 3.9.1
39 Homepage: http://redis.io/
40
41=== added file 'debian/patches/fix-link-ordering'
42--- debian/patches/fix-link-ordering 1970-01-01 00:00:00 +0000
43+++ debian/patches/fix-link-ordering 2011-05-26 18:45:21 +0000
44@@ -0,0 +1,48 @@
45+# Descrption: Fix the failed to build from source due to the --as-needed linking
46+# Bug: http://code.google.com/p/redis/issues/detail?id=562
47+# Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=628056
48+# Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/redis/+bug/771061
49+# Author: Nigel Babu <nigelbabu@ubuntu.com>
50+--- a/src/Makefile
51++++ b/src/Makefile
52+@@ -19,7 +19,7 @@
53+ CCLINK+= -ltcmalloc
54+ CFLAGS+= -DUSE_TCMALLOC
55+ endif
56+-CCOPT= $(CFLAGS) $(CCLINK) $(ARCH) $(PROF)
57++CCOPT= $(CFLAGS) $(ARCH) $(PROF)
58+
59+ PREFIX= /usr/local
60+ INSTALL_BIN= $(PREFIX)/bin
61+@@ -111,26 +111,26 @@
62+ cd ../deps/linenoise && $(MAKE) ARCH="$(ARCH)"
63+
64+ redis-server: $(OBJ)
65+- $(CC) -o $(PRGNAME) $(CCOPT) $(DEBUG) $(OBJ)
66++ $(CC) -o $(PRGNAME) $(CCOPT) $(DEBUG) $(OBJ) $(CCLINK)
67+
68+ redis-benchmark: dependencies $(BENCHOBJ)
69+ cd ../deps/hiredis && $(MAKE) static
70+- $(CC) -o $(BENCHPRGNAME) $(CCOPT) $(DEBUG) $(BENCHOBJ) ../deps/hiredis/libhiredis.a
71++ $(CC) -o $(BENCHPRGNAME) $(CCOPT) $(DEBUG) $(BENCHOBJ) ../deps/hiredis/libhiredis.a $(CCLINK)
72+
73+ redis-benchmark.o:
74+ $(CC) -c $(CFLAGS) -I../deps/hiredis $(DEBUG) $(COMPILE_TIME) $<
75+
76+ redis-cli: dependencies $(CLIOBJ)
77+- $(CC) -o $(CLIPRGNAME) $(CCOPT) $(DEBUG) $(CLIOBJ) ../deps/hiredis/libhiredis.a ../deps/linenoise/linenoise.o
78++ $(CC) -o $(CLIPRGNAME) $(CCOPT) $(DEBUG) $(CLIOBJ) ../deps/hiredis/libhiredis.a ../deps/linenoise/linenoise.o $(CCLINK)
79+
80+ redis-cli.o:
81+ $(CC) -c $(CFLAGS) -I../deps/hiredis -I../deps/linenoise $(DEBUG) $(COMPILE_TIME) $<
82+
83+ redis-check-dump: $(CHECKDUMPOBJ)
84+- $(CC) -o $(CHECKDUMPPRGNAME) $(CCOPT) $(DEBUG) $(CHECKDUMPOBJ)
85++ $(CC) -o $(CHECKDUMPPRGNAME) $(CCOPT) $(DEBUG) $(CHECKDUMPOBJ) $(CCLINK)
86+
87+ redis-check-aof: $(CHECKAOFOBJ)
88+- $(CC) -o $(CHECKAOFPRGNAME) $(CCOPT) $(DEBUG) $(CHECKAOFOBJ)
89++ $(CC) -o $(CHECKAOFPRGNAME) $(CCOPT) $(DEBUG) $(CHECKAOFOBJ) $(CCLINK)
90+
91+ .c.o:
92+ $(CC) -c $(CFLAGS) $(DEBUG) $(COMPILE_TIME) $<
93
94=== modified file 'debian/patches/series'
95--- debian/patches/series 2011-04-25 14:04:29 +0000
96+++ debian/patches/series 2011-05-26 18:45:21 +0000
97@@ -1,1 +1,2 @@
98 debian-changes-2:2.2.5-1
99+fix-link-ordering

Subscribers

People subscribed via source and target branches

to all changes: