Code review comment for lp:~nigelbabu/launchpad/patch-edit-684548

Revision history for this message
Данило Шеган (danilo) wrote :

The fact that the portlet uses something out of date is not a reason to introduce more out-of-dateness. If it appears all the way to the left, you are putting them on the wrong A tag (i.e. it looks nice if I do something like http://pastebin.ubuntu.com/679537/).

When you remove the link text though, you'll probably want to introduce a CSS class on the ID link so you can easily find it with find_tags_by_class or similar.

Also note that your reformatting of the doctest headers (lint probably complained) is slightly incorrect. "\n" is an actual new line indicator, and you should make the follow-up line be of the same length as the text above it. Also, since this is RST (http://en.wikipedia.org/wiki/ReStructuredText), you should use different characters for different levels of headings, eg.

File Attachments of the Bug Report
==================================
...
Patch attachments are shown before non-patch attachments
--------------------------------------------------------
...

« Back to merge proposal