Code review comment for lp:~niemeyer/pyjuju/go-formula-bundle
Revision history for this message
| Gustavo Niemeyer (niemeyer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
[0]
Very good point. Will check it out.
[1]
I don't know what you mean by "exposing the API directly in the bundle". This is a function,
that reads a bundle in memory. I can't see a reason to kill that possibility, even more
considering we can easily decide based on size whether we want to handle something in
memory or not. The documentation also warns about it.
[2]
It's awesome because you have a method on top of a bunch of raw bytes.
It's definitely tested, because ReadBundleBytes depends on it.
[3]
Sorry about that! :-(