Code review comment for lp:~niemeyer/juju-core/resource-not-found

Revision history for this message
Roger Peppe (rogpeppe) wrote :

looks reasonable, but one thought below.

https://codereview.appspot.com/6549056/diff/2002/state/state.go
File state/state.go (right):

https://codereview.appspot.com/6549056/diff/2002/state/state.go#newcode46
state/state.go:46: format string
i'm not sure that i see the benefit in storing the format and args here.
are we really concerned that the work involved in formatting the error
message is going to slow us down?

it's also potentially dangerous - if we pass in a mutable value whose
String value can change, the error may change value after creation.

https://codereview.appspot.com/6549056/

« Back to merge proposal