Code review comment for lp:~niemeyer/juju-core/mstate-machine-watcher

On Tue, Sep 11, 2012 at 3:13 PM, <email address hidden> wrote:
> white:mstate$ cd state
> /home/aram/src/launchpad.net/juju-core/state
> white:state$ g DeepEquals | wc -l
> 89
> white:state$ cd mstate
> /home/aram/src/launchpad.net/juju-core/mstate
> white:mstate$ g DeepEquals | wc -l
> 58

This is counting the number of times we've used DeepEquals, which
doesn't really mean much.

How many of those entries are comparing the private fields of machine?

> I will put omitempty, but this doesn't fix the tests. Entities returned
> by Insert will have TxtRevno always zero but entities returned by other
> querying functions or by Refresh will have a non-zero TxtRevno.

That's a good point. How can we fix it?

gustavo @ http://niemeyer.net