Sorry, it shouldn't be commented out. It should be removed. There's
nothing special about the default group, and the test is broken because
it trusts the system to only have a single group named default, which is
not a given.
> have you tried these tests live? i seem to remember that
> i needed to add the "default" group because it was
> being returned for some of the filtering requests.
Yeah, it was testing it live that forced me to fix it.
https:/ /codereview. appspot. com/7232065/ diff/1/ ec2/ec2t_ test.go
File ec2/ec2t_test.go (right):
https:/ /codereview. appspot. com/7232065/ diff/1/ ec2/ec2t_ test.go# newcode447 test.go: 447: //resp, err := roups([ ]ec2.SecurityGr oup{{Name: "default"}}, nil)
ec2/ec2t_
s.ec2.SecurityG
On 2013/01/31 15:42:43, rog wrote:
> why commented out? this was testing specific ec2test functionality.
Sorry, it shouldn't be commented out. It should be removed. There's
nothing special about the default group, and the test is broken because
it trusts the system to only have a single group named default, which is
not a given.
> have you tried these tests live? i seem to remember that
> i needed to add the "default" group because it was
> being returned for some of the filtering requests.
Yeah, it was testing it live that forced me to fix it.
https:/ /codereview. appspot. com/7232065/