LGTM
https://codereview.appspot.com/7313081/diff/1/s3/multi.go File s3/multi.go (right):
https://codereview.appspot.com/7313081/diff/1/s3/multi.go#newcode282 s3/multi.go:282: if totalSize == 0 || err != nil { That's fine. I wasn't thinking about it being a slice, it does seem correct there.
The concern was stuff like: http://play.golang.org/p/ZcjGU2BgbC
But that doesn't apply here because err has type "error" rather than a custom type that could be a nil pointer.
https://codereview.appspot.com/7313081/
« Back to merge proposal
LGTM
https:/ /codereview. appspot. com/7313081/ diff/1/ s3/multi. go
File s3/multi.go (right):
https:/ /codereview. appspot. com/7313081/ diff/1/ s3/multi. go#newcode282
s3/multi.go:282: if totalSize == 0 || err != nil {
That's fine. I wasn't thinking about it being a slice, it does seem
correct there.
The concern was stuff like: http:// play.golang. org/p/ZcjGU2Bgb C
But that doesn't apply here because err has type "error" rather than a
custom type that could be a nil pointer.
https:/ /codereview. appspot. com/7313081/