Merge lp:~niedbalski/glance/kilo-fix-lp-1447193 into lp:~ubuntu-server-dev/glance/kilo

Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 339
Proposed branch: lp:~niedbalski/glance/kilo-fix-lp-1447193
Merge into: lp:~ubuntu-server-dev/glance/kilo
Diff against target: 72 lines (+53/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/0001-Allow-ramdisk_id-kernel_id-to-be-null-on-schema.patch (+45/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~niedbalski/glance/kilo-fix-lp-1447193
Reviewer Review Type Date Requested Status
Corey Bryant Approve
Review via email: mp+266586@code.launchpad.net

Description of the change

This change fixes LP: #1419823 and LP: #1447215

To post a comment you must log in.
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Thanks Jorge, I commented below.

340. By Jorge Niedbalski

d/p/0001-Allow-ramdisk_id-kernel_id-to-be-null-on-schema.patch:
Allow ramdisk_id, kernel_id to be null on schema. (LP: #1447215).

Addressed @coreycb comments.

341. By Jorge Niedbalski

Addressed @coreycb comments.

342. By Jorge Niedbalski

Addressed @coreycb comments

Revision history for this message
Corey Bryant (corey.bryant) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-05-03 17:44:22 +0000
+++ debian/changelog 2015-08-04 13:54:43 +0000
@@ -1,3 +1,10 @@
1glance (1:2015.1.0-0ubuntu2) vivid; urgency=medium
2
3 * d/p/0001-Allow-ramdisk_id-kernel_id-to-be-null-on-schema.patch:
4 Allow ramdisk_id, kernel_id to be null on schema. (LP: #1447215).
5
6 -- Jorge Niedbalski <jorge.niedbalski@canonical.com> Fri, 31 Jul 2015 11:32:52 -0300
7
1glance (1:2015.1.0-0ubuntu1) vivid; urgency=medium8glance (1:2015.1.0-0ubuntu1) vivid; urgency=medium
29
3 * New upstream release for OpenStack kilo. (LP: #1449744)10 * New upstream release for OpenStack kilo. (LP: #1449744)
411
=== added file 'debian/patches/0001-Allow-ramdisk_id-kernel_id-to-be-null-on-schema.patch'
--- debian/patches/0001-Allow-ramdisk_id-kernel_id-to-be-null-on-schema.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/0001-Allow-ramdisk_id-kernel_id-to-be-null-on-schema.patch 2015-08-04 13:54:43 +0000
@@ -0,0 +1,45 @@
1From 4b269775964f75300d3af56a4c57234d54a32e94 Mon Sep 17 00:00:00 2001
2From: Jorge Niedbalski <jorge.niedbalski@canonical.com>
3Date: Wed, 22 Apr 2015 12:54:29 -0300
4Subject: [PATCH] Allow ramdisk_id, kernel_id to be null on schema
5
6Since is possible to create images with no
7ramdisk_id, kernel_id parameters on glance v1,
8then the schema-image.json needs to be modified to
9allow null, string values for both attributes
10and prevent LP #1447193 to happen with a glance v2
11client.
12
13APIImpact
14
15Closes-Bug: #1447215
16Related-Bug: #1447193
17
18Change-Id: I645c797553ccaa84062f9ad28f2349ae738a0c96
19Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
20(cherry picked from commit 82c63b1df4399db22dfd71e3326a6bfc1b372a9c)
21---
22 etc/schema-image.json | 4 ++--
23 1 file changed, 2 insertions(+), 2 deletions(-)
24
25diff --git a/etc/schema-image.json b/etc/schema-image.json
26index 5aafd6b..d9f433b 100644
27--- a/etc/schema-image.json
28+++ b/etc/schema-image.json
29@@ -1,11 +1,11 @@
30 {
31 "kernel_id": {
32- "type": "string",
33+ "type": ["null", "string"],
34 "pattern": "^([0-9a-fA-F]){8}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){12}$",
35 "description": "ID of image stored in Glance that should be used as the kernel when booting an AMI-style image."
36 },
37 "ramdisk_id": {
38- "type": "string",
39+ "type": ["null", "string"],
40 "pattern": "^([0-9a-fA-F]){8}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){12}$",
41 "description": "ID of image stored in Glance that should be used as the ramdisk when booting an AMI-style image."
42 },
43--
442.1.4
45
046
=== modified file 'debian/patches/series'
--- debian/patches/series 2015-04-10 18:17:03 +0000
+++ debian/patches/series 2015-08-04 13:54:43 +0000
@@ -1,2 +1,3 @@
1sql_conn.patch1sql_conn.patch
2fix-requirements.patch2fix-requirements.patch
30001-Allow-ramdisk_id-kernel_id-to-be-null-on-schema.patch

Subscribers

People subscribed via source and target branches