Code review comment for lp:~niedbalski/charms/trusty/rabbitmq-server/fix-lp-1489053

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Looking through the amulet results, it seems that these tests are still somewhat racey. From what I can tell, it looks like there was a failure to cluster - but the code makes an assumption that the rabbit service is up at the time. That appears to be a separate issue outside of this particular merge proposal.

As an example, running the tests in sts-stack results in a successful pass for all tests as seen http://paste.ubuntu.com/12439865/ (note: just the latest results are shown).

Moving on to the code itself, the code itself looks good and brings the ipv4 and ipv6 paths into the same path, thus I'm happy to merge this.

review: Approve

« Back to merge proposal