Juju Charms Collection
rabbitmq-server package

Code review comment for lp:~niedbalski/charms/trusty/rabbitmq-server/fix-1442443

  1. Trusty Tahr (14.04)
  2. fix-1442443
  3. Merge into next
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Take note that the rabbitmq-server/next amulet tests are being refactored to be in line with other os-charms, to exercise more than just Trusty, and to fix misc issues in logic which are causing false passes.

Those new and refactored tests have are still in review, but have exposed two critical bugs. I would recommend holding on this proposal until the following bugs are resolved and the corresponding branches have landed in next. Then, I'd rebase your proposal and let the updated tests re-run to make sure everything still passes.

bug tldrs:

cluster race bug, affects stable and next
>50% fail to cluster with leadership election
>90% fail to cluster without leadership election
 https://bugs.launchpad.net/charms/+source/rabbitmq-server/+bug/1486177

outright fail on vivid, affects stable and next
100% fail, rmq's pidfile location changed, cron job errors out
https://bugs.launchpad.net/charms/+source/rabbitmq-server/+bug/1485722

review: Needs Resubmitting

« Back to merge proposal