Prometheus Openstack Exporter Charm

Code review comment for ~niedbalski/charm-prometheus-openstack-exporter/+git/charm-prometheus-openstack-exporter:reconfig-on-change

  1. Git
  2. lp:~niedbalski/charm-prometheus-openstack-exporter/+git/charm-prometheus-openstack-exporter
  3. reconfig-on-change
  4. Merge into master
Revision history for this message
Stuart Bishop (stub) wrote :

Looks good. I think the first test could be improved per inline comment, which can be updated before landing if you agree.

review: Approve

« Back to merge proposal