Merge lp:~niedbalski/charm-helpers/sed-support into lp:charm-helpers
Proposed by
Jorge Niedbalski
Status: | Superseded |
---|---|
Proposed branch: | lp:~niedbalski/charm-helpers/sed-support |
Merge into: | lp:charm-helpers |
Diff against target: |
86 lines (+77/-0) 2 files modified
charmhelpers/core/files.py (+45/-0) tests/core/test_files.py (+32/-0) |
To merge this branch: | bzr merge lp:~niedbalski/charm-helpers/sed-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Felipe Reyes (community) | Needs Fixing | ||
charmers | Pending | ||
Review via email:
|
This proposal has been superseded by a proposal from 2015-07-22.
Description of the change
Add a 'sed' function for search/replace patterns on files.
To post a comment you must log in.
I had to apply this patch[0] to be able to run the unit tests, it seems to be a recent regression/change according to this[1] stackoverflow question found by @niedbalski.
[0] nts.txt' ts.txt 2014-11-25 15:07:02 +0000 ts.txt 2015-07-15 16:57:37 +0000
=== modified file 'test_requireme
--- test_requiremen
+++ test_requiremen
@@ -3,7 +3,7 @@
pip
distribute
coverage>=3.6
-mock>=1.0.1
+mock>=1.0.1,<1.1.0
nose>=1.3.1
flake8
testtools==0.9.14 # Before dependent on modern 'six'
[1] http:// stackoverflow. com/questions/ 31417964/ importerror- cannot- import- name-wraps