Merge lp:~freyes/charm-helpers/mock into lp:charm-helpers

Proposed by Felipe Reyes
Status: Merged
Merged at revision: 405
Proposed branch: lp:~freyes/charm-helpers/mock
Merge into: lp:charm-helpers
Diff against target: 12 lines (+1/-1)
1 file modified
test_requirements.txt (+1/-1)
To merge this branch: bzr merge lp:~freyes/charm-helpers/mock
Reviewer Review Type Date Requested Status
Chris Glass (community) Needs Fixing
Review via email: mp+264884@code.launchpad.net

Description of the change

Dear Charmers,

This MP solves a problem we are getting with mock 1.1.3

======================================================================
ERROR: Failure: ImportError (cannot import name wraps)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/sed-support/.venv/local/lib/python2.7/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File "/tmp/sed-support/.venv/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/tmp/sed-support/.venv/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/tmp/sed-support/tests/tools/test_charm_helper_sync.py", line 2, in <module>
    from mock import call, patch
  File "/tmp/sed-support/.venv/local/lib/python2.7/site-packages/mock/__init__.py", line 2, in <module>
    import mock.mock as _mock
  File "/tmp/sed-support/.venv/local/lib/python2.7/site-packages/mock/mock.py", line 68, in <module>
    from six import wraps
ImportError: cannot import name wraps

Thanks,

To post a comment you must log in.
Revision history for this message
Chris Glass (tribaal) wrote :

There are no versions of mock between 1.0.1 and 1.1.0 AFAIK, so this does nothing.

Like was stated in the previous commit message, you need to destroy and recreate your venvs for things to work:

rm -r .venv
rm -r .venv3

review: Needs Fixing
Revision history for this message
Chris Glass (tribaal) wrote :

Oh, it's merged already? Ah well.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test_requirements.txt'
2--- test_requirements.txt 2015-07-15 09:11:59 +0000
3+++ test_requirements.txt 2015-07-15 17:04:39 +0000
4@@ -3,7 +3,7 @@
5 pip
6 distribute
7 coverage>=3.6
8-mock==1.0.1
9+mock>=1.0.1,<1.1.0
10 nose>=1.3.1
11 flake8
12 testtools==0.9.14 # Before dependent on modern 'six'

Subscribers

People subscribed via source and target branches