Terminator

Merge lp:~nicolasr/terminator/clonable into lp:terminator/trunk

  1. clonable
  2. Merge into trunk
Proposed by Nicolas Roman
Status: Rejected
Rejected by: Stephen Boddy
Proposed branch: lp:~nicolasr/terminator/clonable
Merge into: lp:terminator/trunk
To merge this branch: bzr merge lp:~nicolasr/terminator/clonable
Reviewer Review Type Date Requested Status
Chris Jones (community) Abstain
Review via email: mp+2574@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris Jones (cmsj) wrote :

It's an interesting feature, my concern is the addition of more context menu items for something that may not be widely useful until we have proper support for multiple profiles.
Perhaps it's something that the SSHerminator fork would like to see though?

review: Abstain
Revision history for this message
Chris Jones (cmsj) wrote :

lp:~cmsj/terminator/epic-refactor is a branch I am working on that completely refactors all of Terminator to make it more sustainable as a project.
One of the features I've added is plugins and I suspect it would be entirely possible for you to convert your clonable feature into a plugin, if you still wish to see it exist as a feature :)

Revision history for this message
Nicolas Roman (nicolasr) wrote :

Hi Chris,

It would be a pleasure to convert the clonable feature into a plugin.
But a little more precisions about how plugins work would be welcome.
Do you have anything to help me understand the whole thing or do I
have to get down to the source code basement ?

Thanks in advance,

nicolas

2010/1/5 Chris Jones <email address hidden>:
> lp:~cmsj/terminator/epic-refactor is a branch I am working on that completely refactors all of Terminator to make it more sustainable as a project.
> One of the features I've added is plugins and I suspect it would be entirely possible for you to convert your clonable feature into a plugin, if you still wish to see it exist as a feature :)
> --
> https://code.edge.launchpad.net/~nicolasr/terminator/clonable/+merge/2574
> You are the owner of lp:~nicolasr/terminator/clonable.
>

Revision history for this message
Chris Jones (cmsj) wrote :

Nicolas: There are no docs yet, unfortunately. There are a few example plugins though. If we need to provide more API features for plugins, I would be happy to look at doing so.

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Nicolas: This branch has sat idle for a very long time. For housekeeping I'm going to reject to remove it from the outstanding branches waiting for merging.

Unmerged revisions

628. By Nicolas Roman <nicolasr@abcdebian>

Added menu items to clone horizontally and vertically

627. By Nicolas Roman <nicolasr@abcdebian>

Add cloning capabilities, vertically and horizontally.