Merge lp:~nicolas-doffay/unity8/search-history-persist into lp:unity8

Proposed by Nicolas d'Offay
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 502
Merged at revision: 545
Proposed branch: lp:~nicolas-doffay/unity8/search-history-persist
Merge into: lp:unity8
Diff against target: 126 lines (+12/-6)
8 files modified
Components/PageHeader.qml (+1/-1)
Dash/Dash.qml (+3/-0)
Dash/DashApps.qml (+3/-0)
Dash/DashContent.qml (+2/-1)
Dash/GenericScopeView.qml (+1/-0)
Shell.qml (+0/-2)
tests/qmltests/Components/tst_PageHeader.qml (+1/-0)
tests/qmltests/Dash/tst_DashContent.qml (+1/-2)
To merge this branch: bzr merge lp:~nicolas-doffay/unity8/search-history-persist
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Albert Astals Cid (community) Approve
Michał Sawicz Pending
Review via email: mp+193935@code.launchpad.net

Commit message

Search history is now persistent across all scopes and remains in QML.

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

Please add a test for this.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:499
http://jenkins.qa.ubuntu.com/job/unity8-ci/1586/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/515/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/503/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/152
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/110
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/110
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/110/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/110
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/476/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/515
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/515/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/503
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/503/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3156/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1136

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1586/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:500
http://jenkins.qa.ubuntu.com/job/unity8-ci/1591/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/531/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/519/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/157
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/115
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/115
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/115
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/490/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/531
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/531/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/519
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/519/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2987/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3169/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1151
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1152

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1591/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:500
http://jenkins.qa.ubuntu.com/job/unity8-ci/1595/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/558
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/546
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/161
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/119
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/119
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/119/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/119
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/514
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/558
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/558/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/546
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/546/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/3012
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3194
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1207
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1208

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1595/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

Mock scopes do not have a mock page header implemented. Holding off on tests as advised.

Revision history for this message
Albert Astals Cid (aacid) wrote :

property alias searchHistory: scopeView.searchHistory
in DashApps is basically an alias to itself, no?

review: Needs Fixing
Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

That was my assumption too, but if I don't add that alias the searchHistory is null.

Revision history for this message
Albert Astals Cid (aacid) wrote :

True, please add a comment since that seems some limitation/bug in Qt, maybe something like https://bugreports.qt-project.org/browse/QTBUG-30493

Revision history for this message
Albert Astals Cid (aacid) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/695/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/3220/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/746
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/734/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/257
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-autolanding/81
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/81
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/81/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-autolanding/81
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/680
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/746
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/746/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/734
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/734/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3363/console
    SUCCESS: http://s-jenkins:8080/job/touch-flash-device/1452

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Needs remerging

review: Needs Fixing
502. By Nicolas d'Offay

Merged trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:502
http://jenkins.qa.ubuntu.com/job/unity8-ci/1672/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/864
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/852
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/303
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/195
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/196
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/196/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/195
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/775
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/864
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/864/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/852
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/852/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3453
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1542

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1672/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Merge looks good to me. Ci seems to be acting weird, will keep retriggering CI runs until we can safely land it.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:502
http://jenkins.qa.ubuntu.com/job/unity8-ci/1677/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/900/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/883/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/322
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/200
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/201
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/201/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/200
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/810/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/900
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/900/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/883
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/883/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3484/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1573

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1677/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:502
http://jenkins.qa.ubuntu.com/job/unity8-ci/1681/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/919
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/903
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/329
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/204
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/205
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/205/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/204
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/827
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/919
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/919/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/903
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/903/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3502
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1592

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1681/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:502
http://jenkins.qa.ubuntu.com/job/unity8-ci/1687/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/942
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/926
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/344
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/210
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/211
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/211/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/210
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/846
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/942
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/942/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/926
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/926/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3521
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1620

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1687/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Components/PageHeader.qml'
--- Components/PageHeader.qml 2013-11-11 11:29:19 +0000
+++ Components/PageHeader.qml 2013-11-19 14:34:01 +0000
@@ -30,7 +30,7 @@
3030
31 property bool searchEntryEnabled: false31 property bool searchEntryEnabled: false
32 property alias searchQuery: searchField.text32 property alias searchQuery: searchField.text
33 property ListModel searchHistory: SearchHistoryModel {}33 property ListModel searchHistory
34 property Scope scope34 property Scope scope
3535
36 height: units.gu(8.5)36 height: units.gu(8.5)
3737
=== modified file 'Dash/Dash.qml'
--- Dash/Dash.qml 2013-10-25 11:24:50 +0000
+++ Dash/Dash.qml 2013-11-19 14:34:01 +0000
@@ -26,6 +26,8 @@
2626
27 visible: shown27 visible: shown
2828
29 property ListModel searchHistory: SearchHistoryModel {}
30
29 property alias contentProgress: dashContent.contentProgress31 property alias contentProgress: dashContent.contentProgress
30 property string showScopeOnLoaded: "home.scope"32 property string showScopeOnLoaded: "home.scope"
31 property real contentScale: 1.033 property real contentScale: 1.0
@@ -63,6 +65,7 @@
63 anchors.fill: parent65 anchors.fill: parent
64 model: filteredScopes66 model: filteredScopes
65 scopes: scopes67 scopes: scopes
68 searchHistory: dash.searchHistory
66 onMovementStarted: dashbar.startNavigation()69 onMovementStarted: dashbar.startNavigation()
67 onMovementEnded: dashbar.stopNavigation()70 onMovementEnded: dashbar.stopNavigation()
68 onContentFlickStarted: dashbar.finishNavigation()71 onContentFlickStarted: dashbar.finishNavigation()
6972
=== modified file 'Dash/DashApps.qml'
--- Dash/DashApps.qml 2013-10-03 11:48:24 +0000
+++ Dash/DashApps.qml 2013-11-19 14:34:01 +0000
@@ -30,6 +30,9 @@
30 property var mainStageApplicationsModel: shell.applicationManager.mainStageApplications30 property var mainStageApplicationsModel: shell.applicationManager.mainStageApplications
31 property var sideStageApplicationModel: shell.applicationManager.sideStageApplications31 property var sideStageApplicationModel: shell.applicationManager.sideStageApplications
3232
33 //FIXME an alias to itself shouldn't be required. More than likely a Qt bug. Try removing with newer Qt.
34 property alias searchHistory: scopeView.searchHistory
35
33 ListModel {36 ListModel {
34 id: dummyVisibilityModifier37 id: dummyVisibilityModifier
3538
3639
=== modified file 'Dash/DashContent.qml'
--- Dash/DashContent.qml 2013-10-21 08:15:28 +0000
+++ Dash/DashContent.qml 2013-11-19 14:34:01 +0000
@@ -27,6 +27,7 @@
27 property alias currentIndex: dashContentList.currentIndex27 property alias currentIndex: dashContentList.currentIndex
2828
29 property ScopeDelegateMapper scopeMapper : ScopeDelegateMapper {}29 property ScopeDelegateMapper scopeMapper : ScopeDelegateMapper {}
30 property ListModel searchHistory
3031
31 signal movementStarted()32 signal movementStarted()
32 signal movementEnded()33 signal movementEnded()
@@ -127,7 +128,7 @@
127 onLoaded: {128 onLoaded: {
128 item.scope = Qt.binding(function() { return scope })129 item.scope = Qt.binding(function() { return scope })
129 item.isCurrent = Qt.binding(function() { return visible && ListView.isCurrentItem })130 item.isCurrent = Qt.binding(function() { return visible && ListView.isCurrentItem })
130 item.searchHistory = Qt.binding(function() { return shell.searchHistory })131 item.searchHistory = Qt.binding(function() { return dashContent.searchHistory })
131 dashContentList.movementStarted.connect(item.movementStarted)132 dashContentList.movementStarted.connect(item.movementStarted)
132 dashContent.positionedAtBeginning.connect(item.positionedAtBeginning)133 dashContent.positionedAtBeginning.connect(item.positionedAtBeginning)
133 dashContent.scopeLoaded(item.scope.id)134 dashContent.scopeLoaded(item.scope.id)
134135
=== modified file 'Dash/GenericScopeView.qml'
--- Dash/GenericScopeView.qml 2013-11-19 10:44:14 +0000
+++ Dash/GenericScopeView.qml 2013-11-19 14:34:01 +0000
@@ -293,6 +293,7 @@
293 text: scopeView.scope.name293 text: scopeView.scope.name
294 searchEntryEnabled: true294 searchEntryEnabled: true
295 scope: scopeView.scope295 scope: scopeView.scope
296 searchHistory: scopeView.searchHistory
296 }297 }
297 }298 }
298299
299300
=== modified file 'Shell.qml'
--- Shell.qml 2013-11-08 08:48:11 +0000
+++ Shell.qml 2013-11-19 14:34:01 +0000
@@ -61,8 +61,6 @@
61 }61 }
62 }62 }
6363
64 property ListModel searchHistory: SearchHistoryModel {}
65
66 property var applicationManager: ApplicationManagerWrapper {}64 property var applicationManager: ApplicationManagerWrapper {}
6765
68 Binding {66 Binding {
6967
=== modified file 'tests/qmltests/Components/tst_PageHeader.qml'
--- tests/qmltests/Components/tst_PageHeader.qml 2013-11-08 16:24:45 +0000
+++ tests/qmltests/Components/tst_PageHeader.qml 2013-11-19 14:34:01 +0000
@@ -214,6 +214,7 @@
214 scope: scopeMock214 scope: scopeMock
215215
216 searchEntryEnabled: true216 searchEntryEnabled: true
217 searchHistory: SearchHistoryModel {}
217 text: "%^$%^%^&%^&%^$%GHR%"218 text: "%^$%^%^&%^&%^$%GHR%"
218 }219 }
219220
220221
=== modified file 'tests/qmltests/Dash/tst_DashContent.qml'
--- tests/qmltests/Dash/tst_DashContent.qml 2013-11-14 14:59:16 +0000
+++ tests/qmltests/Dash/tst_DashContent.qml 2013-11-19 14:34:01 +0000
@@ -26,8 +26,6 @@
26 width: units.gu(40)26 width: units.gu(40)
27 height: units.gu(80)27 height: units.gu(80)
2828
29 property ListModel searchHistory: ListModel {}
30
31 Item {29 Item {
32 // Fake. Make a few components less noisy30 // Fake. Make a few components less noisy
33 id: greeter31 id: greeter
@@ -60,6 +58,7 @@
60 scopes : scopesModel58 scopes : scopesModel
6159
62 scopeMapper : scopeDelegateMapper60 scopeMapper : scopeDelegateMapper
61 searchHistory: ListModel {}
63 }62 }
6463
65 ScopeDelegateMapper {64 ScopeDelegateMapper {

Subscribers

People subscribed via source and target branches