Merge lp:~nicolas-doffay/unity8/search-history-persist into lp:unity8

Proposed by Nicolas d'Offay
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 502
Merged at revision: 545
Proposed branch: lp:~nicolas-doffay/unity8/search-history-persist
Merge into: lp:unity8
Diff against target: 126 lines (+12/-6)
8 files modified
Components/PageHeader.qml (+1/-1)
Dash/Dash.qml (+3/-0)
Dash/DashApps.qml (+3/-0)
Dash/DashContent.qml (+2/-1)
Dash/GenericScopeView.qml (+1/-0)
Shell.qml (+0/-2)
tests/qmltests/Components/tst_PageHeader.qml (+1/-0)
tests/qmltests/Dash/tst_DashContent.qml (+1/-2)
To merge this branch: bzr merge lp:~nicolas-doffay/unity8/search-history-persist
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Albert Astals Cid (community) Approve
Michał Sawicz Pending
Review via email: mp+193935@code.launchpad.net

Commit message

Search history is now persistent across all scopes and remains in QML.

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

Please add a test for this.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:499
http://jenkins.qa.ubuntu.com/job/unity8-ci/1586/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/515/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/503/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/152
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/110
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/110
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/110/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/110
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/476/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/515
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/515/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/503
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/503/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3156/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1136

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1586/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:500
http://jenkins.qa.ubuntu.com/job/unity8-ci/1591/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/531/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/519/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/157
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/115
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/115
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/115
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/490/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/531
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/531/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/519
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/519/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2987/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3169/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1151
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1152

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1591/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:500
http://jenkins.qa.ubuntu.com/job/unity8-ci/1595/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/558
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/546
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/161
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/119
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/119
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/119/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/119
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/514
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/558
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/558/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/546
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/546/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/3012
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3194
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1207
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1208

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1595/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

Mock scopes do not have a mock page header implemented. Holding off on tests as advised.

Revision history for this message
Albert Astals Cid (aacid) wrote :

property alias searchHistory: scopeView.searchHistory
in DashApps is basically an alias to itself, no?

review: Needs Fixing
Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

That was my assumption too, but if I don't add that alias the searchHistory is null.

Revision history for this message
Albert Astals Cid (aacid) wrote :

True, please add a comment since that seems some limitation/bug in Qt, maybe something like https://bugreports.qt-project.org/browse/QTBUG-30493

Revision history for this message
Albert Astals Cid (aacid) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/695/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/3220/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/746
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/734/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/257
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-autolanding/81
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/81
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/81/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-autolanding/81
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/680
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/746
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/746/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/734
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/734/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3363/console
    SUCCESS: http://s-jenkins:8080/job/touch-flash-device/1452

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Needs remerging

review: Needs Fixing
502. By Nicolas d'Offay

Merged trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:502
http://jenkins.qa.ubuntu.com/job/unity8-ci/1672/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/864
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/852
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/303
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/195
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/196
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/196/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/195
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/775
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/864
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/864/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/852
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/852/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3453
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1542

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1672/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Merge looks good to me. Ci seems to be acting weird, will keep retriggering CI runs until we can safely land it.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:502
http://jenkins.qa.ubuntu.com/job/unity8-ci/1677/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/900/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/883/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/322
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/200
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/201
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/201/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/200
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/810/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/900
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/900/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/883
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/883/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3484/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1573

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1677/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:502
http://jenkins.qa.ubuntu.com/job/unity8-ci/1681/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/919
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/903
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/329
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/204
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/205
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/205/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/204
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/827
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/919
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/919/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/903
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/903/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3502
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1592

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1681/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:502
http://jenkins.qa.ubuntu.com/job/unity8-ci/1687/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/942
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/926
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/344
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/210
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/211
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/211/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/210
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/846
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/942
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/942/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/926
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/926/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3521
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1620

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1687/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Components/PageHeader.qml'
2--- Components/PageHeader.qml 2013-11-11 11:29:19 +0000
3+++ Components/PageHeader.qml 2013-11-19 14:34:01 +0000
4@@ -30,7 +30,7 @@
5
6 property bool searchEntryEnabled: false
7 property alias searchQuery: searchField.text
8- property ListModel searchHistory: SearchHistoryModel {}
9+ property ListModel searchHistory
10 property Scope scope
11
12 height: units.gu(8.5)
13
14=== modified file 'Dash/Dash.qml'
15--- Dash/Dash.qml 2013-10-25 11:24:50 +0000
16+++ Dash/Dash.qml 2013-11-19 14:34:01 +0000
17@@ -26,6 +26,8 @@
18
19 visible: shown
20
21+ property ListModel searchHistory: SearchHistoryModel {}
22+
23 property alias contentProgress: dashContent.contentProgress
24 property string showScopeOnLoaded: "home.scope"
25 property real contentScale: 1.0
26@@ -63,6 +65,7 @@
27 anchors.fill: parent
28 model: filteredScopes
29 scopes: scopes
30+ searchHistory: dash.searchHistory
31 onMovementStarted: dashbar.startNavigation()
32 onMovementEnded: dashbar.stopNavigation()
33 onContentFlickStarted: dashbar.finishNavigation()
34
35=== modified file 'Dash/DashApps.qml'
36--- Dash/DashApps.qml 2013-10-03 11:48:24 +0000
37+++ Dash/DashApps.qml 2013-11-19 14:34:01 +0000
38@@ -30,6 +30,9 @@
39 property var mainStageApplicationsModel: shell.applicationManager.mainStageApplications
40 property var sideStageApplicationModel: shell.applicationManager.sideStageApplications
41
42+ //FIXME an alias to itself shouldn't be required. More than likely a Qt bug. Try removing with newer Qt.
43+ property alias searchHistory: scopeView.searchHistory
44+
45 ListModel {
46 id: dummyVisibilityModifier
47
48
49=== modified file 'Dash/DashContent.qml'
50--- Dash/DashContent.qml 2013-10-21 08:15:28 +0000
51+++ Dash/DashContent.qml 2013-11-19 14:34:01 +0000
52@@ -27,6 +27,7 @@
53 property alias currentIndex: dashContentList.currentIndex
54
55 property ScopeDelegateMapper scopeMapper : ScopeDelegateMapper {}
56+ property ListModel searchHistory
57
58 signal movementStarted()
59 signal movementEnded()
60@@ -127,7 +128,7 @@
61 onLoaded: {
62 item.scope = Qt.binding(function() { return scope })
63 item.isCurrent = Qt.binding(function() { return visible && ListView.isCurrentItem })
64- item.searchHistory = Qt.binding(function() { return shell.searchHistory })
65+ item.searchHistory = Qt.binding(function() { return dashContent.searchHistory })
66 dashContentList.movementStarted.connect(item.movementStarted)
67 dashContent.positionedAtBeginning.connect(item.positionedAtBeginning)
68 dashContent.scopeLoaded(item.scope.id)
69
70=== modified file 'Dash/GenericScopeView.qml'
71--- Dash/GenericScopeView.qml 2013-11-19 10:44:14 +0000
72+++ Dash/GenericScopeView.qml 2013-11-19 14:34:01 +0000
73@@ -293,6 +293,7 @@
74 text: scopeView.scope.name
75 searchEntryEnabled: true
76 scope: scopeView.scope
77+ searchHistory: scopeView.searchHistory
78 }
79 }
80
81
82=== modified file 'Shell.qml'
83--- Shell.qml 2013-11-08 08:48:11 +0000
84+++ Shell.qml 2013-11-19 14:34:01 +0000
85@@ -61,8 +61,6 @@
86 }
87 }
88
89- property ListModel searchHistory: SearchHistoryModel {}
90-
91 property var applicationManager: ApplicationManagerWrapper {}
92
93 Binding {
94
95=== modified file 'tests/qmltests/Components/tst_PageHeader.qml'
96--- tests/qmltests/Components/tst_PageHeader.qml 2013-11-08 16:24:45 +0000
97+++ tests/qmltests/Components/tst_PageHeader.qml 2013-11-19 14:34:01 +0000
98@@ -214,6 +214,7 @@
99 scope: scopeMock
100
101 searchEntryEnabled: true
102+ searchHistory: SearchHistoryModel {}
103 text: "%^$%^%^&%^&%^$%GHR%"
104 }
105
106
107=== modified file 'tests/qmltests/Dash/tst_DashContent.qml'
108--- tests/qmltests/Dash/tst_DashContent.qml 2013-11-14 14:59:16 +0000
109+++ tests/qmltests/Dash/tst_DashContent.qml 2013-11-19 14:34:01 +0000
110@@ -26,8 +26,6 @@
111 width: units.gu(40)
112 height: units.gu(80)
113
114- property ListModel searchHistory: ListModel {}
115-
116 Item {
117 // Fake. Make a few components less noisy
118 id: greeter
119@@ -60,6 +58,7 @@
120 scopes : scopesModel
121
122 scopeMapper : scopeDelegateMapper
123+ searchHistory: ListModel {}
124 }
125
126 ScopeDelegateMapper {

Subscribers

People subscribed via source and target branches