Merge lp:~nicolas-doffay/unity8/search-history-persist into lp:unity8
- search-history-persist
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 502 |
Merged at revision: | 545 |
Proposed branch: | lp:~nicolas-doffay/unity8/search-history-persist |
Merge into: | lp:unity8 |
Diff against target: |
126 lines (+12/-6) 8 files modified
Components/PageHeader.qml (+1/-1) Dash/Dash.qml (+3/-0) Dash/DashApps.qml (+3/-0) Dash/DashContent.qml (+2/-1) Dash/GenericScopeView.qml (+1/-0) Shell.qml (+0/-2) tests/qmltests/Components/tst_PageHeader.qml (+1/-0) tests/qmltests/Dash/tst_DashContent.qml (+1/-2) |
To merge this branch: | bzr merge lp:~nicolas-doffay/unity8/search-history-persist |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Albert Astals Cid (community) | Approve | ||
Michał Sawicz | Pending | ||
Review via email: mp+193935@code.launchpad.net |
Commit message
Search history is now persistent across all scopes and remains in QML.
Description of the change
Michał Sawicz (saviq) wrote : | # |
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:498
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:499
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
FAILURE: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:500
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:500
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Nicolas d'Offay (nicolas-doffay) wrote : | # |
Mock scopes do not have a mock page header implemented. Holding off on tests as advised.
Albert Astals Cid (aacid) wrote : | # |
property alias searchHistory: scopeView.
in DashApps is basically an alias to itself, no?
Nicolas d'Offay (nicolas-doffay) wrote : | # |
That was my assumption too, but if I don't add that alias the searchHistory is null.
Albert Astals Cid (aacid) wrote : | # |
True, please add a comment since that seems some limitation/bug in Qt, maybe something like https:/
Albert Astals Cid (aacid) : | # |
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
FAILURE: http://
SUCCESS: http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:501
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
Albert Astals Cid (aacid) wrote : | # |
Needs remerging
- 502. By Nicolas d'Offay
-
Merged trunk.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:502
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Albert Astals Cid (aacid) wrote : | # |
Merge looks good to me. Ci seems to be acting weird, will keep retriggering CI runs until we can safely land it.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:502
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
FAILURE: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:502
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:502
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Preview Diff
1 | === modified file 'Components/PageHeader.qml' |
2 | --- Components/PageHeader.qml 2013-11-11 11:29:19 +0000 |
3 | +++ Components/PageHeader.qml 2013-11-19 14:34:01 +0000 |
4 | @@ -30,7 +30,7 @@ |
5 | |
6 | property bool searchEntryEnabled: false |
7 | property alias searchQuery: searchField.text |
8 | - property ListModel searchHistory: SearchHistoryModel {} |
9 | + property ListModel searchHistory |
10 | property Scope scope |
11 | |
12 | height: units.gu(8.5) |
13 | |
14 | === modified file 'Dash/Dash.qml' |
15 | --- Dash/Dash.qml 2013-10-25 11:24:50 +0000 |
16 | +++ Dash/Dash.qml 2013-11-19 14:34:01 +0000 |
17 | @@ -26,6 +26,8 @@ |
18 | |
19 | visible: shown |
20 | |
21 | + property ListModel searchHistory: SearchHistoryModel {} |
22 | + |
23 | property alias contentProgress: dashContent.contentProgress |
24 | property string showScopeOnLoaded: "home.scope" |
25 | property real contentScale: 1.0 |
26 | @@ -63,6 +65,7 @@ |
27 | anchors.fill: parent |
28 | model: filteredScopes |
29 | scopes: scopes |
30 | + searchHistory: dash.searchHistory |
31 | onMovementStarted: dashbar.startNavigation() |
32 | onMovementEnded: dashbar.stopNavigation() |
33 | onContentFlickStarted: dashbar.finishNavigation() |
34 | |
35 | === modified file 'Dash/DashApps.qml' |
36 | --- Dash/DashApps.qml 2013-10-03 11:48:24 +0000 |
37 | +++ Dash/DashApps.qml 2013-11-19 14:34:01 +0000 |
38 | @@ -30,6 +30,9 @@ |
39 | property var mainStageApplicationsModel: shell.applicationManager.mainStageApplications |
40 | property var sideStageApplicationModel: shell.applicationManager.sideStageApplications |
41 | |
42 | + //FIXME an alias to itself shouldn't be required. More than likely a Qt bug. Try removing with newer Qt. |
43 | + property alias searchHistory: scopeView.searchHistory |
44 | + |
45 | ListModel { |
46 | id: dummyVisibilityModifier |
47 | |
48 | |
49 | === modified file 'Dash/DashContent.qml' |
50 | --- Dash/DashContent.qml 2013-10-21 08:15:28 +0000 |
51 | +++ Dash/DashContent.qml 2013-11-19 14:34:01 +0000 |
52 | @@ -27,6 +27,7 @@ |
53 | property alias currentIndex: dashContentList.currentIndex |
54 | |
55 | property ScopeDelegateMapper scopeMapper : ScopeDelegateMapper {} |
56 | + property ListModel searchHistory |
57 | |
58 | signal movementStarted() |
59 | signal movementEnded() |
60 | @@ -127,7 +128,7 @@ |
61 | onLoaded: { |
62 | item.scope = Qt.binding(function() { return scope }) |
63 | item.isCurrent = Qt.binding(function() { return visible && ListView.isCurrentItem }) |
64 | - item.searchHistory = Qt.binding(function() { return shell.searchHistory }) |
65 | + item.searchHistory = Qt.binding(function() { return dashContent.searchHistory }) |
66 | dashContentList.movementStarted.connect(item.movementStarted) |
67 | dashContent.positionedAtBeginning.connect(item.positionedAtBeginning) |
68 | dashContent.scopeLoaded(item.scope.id) |
69 | |
70 | === modified file 'Dash/GenericScopeView.qml' |
71 | --- Dash/GenericScopeView.qml 2013-11-19 10:44:14 +0000 |
72 | +++ Dash/GenericScopeView.qml 2013-11-19 14:34:01 +0000 |
73 | @@ -293,6 +293,7 @@ |
74 | text: scopeView.scope.name |
75 | searchEntryEnabled: true |
76 | scope: scopeView.scope |
77 | + searchHistory: scopeView.searchHistory |
78 | } |
79 | } |
80 | |
81 | |
82 | === modified file 'Shell.qml' |
83 | --- Shell.qml 2013-11-08 08:48:11 +0000 |
84 | +++ Shell.qml 2013-11-19 14:34:01 +0000 |
85 | @@ -61,8 +61,6 @@ |
86 | } |
87 | } |
88 | |
89 | - property ListModel searchHistory: SearchHistoryModel {} |
90 | - |
91 | property var applicationManager: ApplicationManagerWrapper {} |
92 | |
93 | Binding { |
94 | |
95 | === modified file 'tests/qmltests/Components/tst_PageHeader.qml' |
96 | --- tests/qmltests/Components/tst_PageHeader.qml 2013-11-08 16:24:45 +0000 |
97 | +++ tests/qmltests/Components/tst_PageHeader.qml 2013-11-19 14:34:01 +0000 |
98 | @@ -214,6 +214,7 @@ |
99 | scope: scopeMock |
100 | |
101 | searchEntryEnabled: true |
102 | + searchHistory: SearchHistoryModel {} |
103 | text: "%^$%^%^&%^&%^$%GHR%" |
104 | } |
105 | |
106 | |
107 | === modified file 'tests/qmltests/Dash/tst_DashContent.qml' |
108 | --- tests/qmltests/Dash/tst_DashContent.qml 2013-11-14 14:59:16 +0000 |
109 | +++ tests/qmltests/Dash/tst_DashContent.qml 2013-11-19 14:34:01 +0000 |
110 | @@ -26,8 +26,6 @@ |
111 | width: units.gu(40) |
112 | height: units.gu(80) |
113 | |
114 | - property ListModel searchHistory: ListModel {} |
115 | - |
116 | Item { |
117 | // Fake. Make a few components less noisy |
118 | id: greeter |
119 | @@ -60,6 +58,7 @@ |
120 | scopes : scopesModel |
121 | |
122 | scopeMapper : scopeDelegateMapper |
123 | + searchHistory: ListModel {} |
124 | } |
125 | |
126 | ScopeDelegateMapper { |
Please add a test for this.