Code review comment for lp:~nicolas-doffay/unity8/filter-selector

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Looking at https://docs.google.com/a/canonical.com/presentation/d/1X3_G6reCpcFJxzxn1Xtv9wK5n3-wOW-6z2l0qSZ8-sg/present#slide=id.gefa49ee0_021 for reference:

The first option seems to always be selected, be it "All" or something else.

The filter icon is too close to the right edge.

The filter button doesn't change to orange when active.

I can expand two filters at the same time - please confirm that's the desired behaviour.

There's no way to cancel a selection - shouldn't tapping outside of the expanded selector collapse it - please confirm the desired behaviour.

The expanded height is hardcoded, so when you make the window smaller, you can't scroll the filters any more. We should really look into fixing bug #1169258 first - and use it here.

The overlay is transparent to input at the 2GU margin between the crop line and the filter panel's edge.

review: Needs Fixing

« Back to merge proposal