Code review comment for lp:~nicolas-doffay/unity8/filter-selector

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Before I do the code review, please fix/clarify those things:

* The search lens icon is too big and shouldn't actually be that search lens but the filter icon.
* The filter icon should be inside the text field, as secondaryItem.
* Should the bottomDividers be a drag handle? I would assume you can drag this up again to dismiss
* tapping in the empty space at the bottom should dismiss it
* when filters opened, swiping the dash should not work until dismissed.
* the animation feels weird. It covers everything except the searchfield. Please check with design.
* it breaks the narrowMode decision. Try opening the search field and drag it smaller/bigger and compare that to trunk

review: Needs Fixing

« Back to merge proposal