Code review comment for lp:~nicolas-doffay/unity8/category-transition-speed-fix

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

That's not enough, I'm afraid.

The intermediate height is more complicated: it needs to take y and uncollapsed height into account. Say the category is scrolled up so that its first row is offscreen, you animate its height to genericScopeHeight, but that means the last row of the expanded category won't get animated (just scroll a category up so that it's offscreen and expand it then - you'll see the bottom behaving incorrectly). If uncollapsedHeight is smaller than genericScopeHeight, you animate to genericScopeHeight and then collapse back to uncollapsedHeight (you can see that when expanding "Applications" in Home - the second category disappears for a fraction of a second).

review: Needs Fixing

« Back to merge proposal