Code review comment for lp:~nicolas-doffay/ubuntu-ui-toolkit/fix-1240019

Revision history for this message
Zsombor Egri (zsombi) wrote :

OK. So, detecting whether the component is used as ListItem or not is useless here, however the property name is not so QMLish, let's say in this way. So my proposal to this would be":
1. either to use OptionSelector as base class for ItemSelector, and define different style (or no style at all) for ItemSelector, and configure the 'contains' property needs with the style item itself (i.e. define a property in the style which when exist, would drive the thin dividers, etc from OptionSelector; the ItemSelectorStyle could not have this property set or even defined)
2. Rename the 'contains' property to something more descriptive

I'd prefer the first approach, then we would have clear differentiation on which to be used where, but still similar functionality.

review: Needs Fixing

« Back to merge proposal