Merge lp:~nico-inattendu/luciole/bug_521371 into lp:luciole/0.8

Proposed by NicoInattendu
Status: Rejected
Rejected by: NicoInattendu
Proposed branch: lp:~nico-inattendu/luciole/bug_521371
Merge into: lp:luciole/0.8
Diff against target: 135 lines (+94/-6)
1 file modified
lucioLib/gui/dialog_project_properties.py (+94/-6)
To merge this branch: bzr merge lp:~nico-inattendu/luciole/bug_521371
Reviewer Review Type Date Requested Status
NicoInattendu Needs Resubmitting
Review via email: mp+19273@code.launchpad.net
To post a comment you must log in.
Revision history for this message
NicoInattendu (nico-inattendu) wrote :

some comments not clear :
widgetyy instead of widget
self.webcam_widdget_table_position not initailized

review: Needs Resubmitting

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lucioLib/gui/dialog_project_properties.py'
--- lucioLib/gui/dialog_project_properties.py 2010-02-07 17:46:34 +0000
+++ lucioLib/gui/dialog_project_properties.py 2010-02-13 16:14:12 +0000
@@ -31,8 +31,12 @@
31import pango31import pango
3232
33from .. import luciole_constants as LCONST33from .. import luciole_constants as LCONST
34from .. import luciole_exceptions as LEXCEP
34import webcam_detection_widget as LWDW35import webcam_detection_widget as LWDW
3536
37import logging
38module_logger = logging.getLogger('luciole')
39
3640
37#type of widgets for displaying webcam data41#type of widgets for displaying webcam data
38(LABEL,ENTRY,SCALE)=range(3)42(LABEL,ENTRY,SCALE)=range(3)
@@ -102,6 +106,9 @@
102 106
103 def __init__(self,main_window, project, cb_project_change) :107 def __init__(self,main_window, project, cb_project_change) :
104 """ create a Dialog with project properties and display it"""108 """ create a Dialog with project properties and display it"""
109 # init logger
110 self.logger = logging.getLogger('luciole')
111
105 self._dialog = gtk.Dialog ( _(self._title),112 self._dialog = gtk.Dialog ( _(self._title),
106 main_window,113 main_window,
107 gtk.DIALOG_MODAL | gtk.DIALOG_DESTROY_WITH_PARENT,114 gtk.DIALOG_MODAL | gtk.DIALOG_DESTROY_WITH_PARENT,
@@ -232,11 +239,22 @@
232 widget.set_alignment(xalign = 0.0, yalign = 0.5) # left justification 239 widget.set_alignment(xalign = 0.0, yalign = 0.5) # left justification
233 widget.set_text("%s"%self._project['webcam_data'][key])240 widget.set_text("%s"%self._project['webcam_data'][key])
234 elif self._WEBCAM_PREFS[key]['type'] == SCALE :241 elif self._WEBCAM_PREFS[key]['type'] == SCALE :
235 widget = Framerate_scale(self._project['webcam_data'][key],242 # display scale bar if several framerates are available
236 self._project['webcam_data']['framerate_selected'],243 if len( self._project['webcam_data'][key]) > 1 :
237 self._cb_framerate_selected)244 widget = Framerate_scale(self._project['webcam_data'][key],
245 self._project['webcam_data']['framerate_selected'],
246 self._cb_framerate_selected)
247 elif len( self._project['webcam_data'][key]) == 1 :
248 widget = gtk.Label()
249 widget.set_alignment(xalign = 0.0, yalign = 0.5) # left justification
250 # in that case framerate_selected = framerate_list[0]
251 framerate = int(self._project['webcam_data']['framerate_selected'][0]/self._project['webcam_data']['framerate_selected'][1])
252 widget.set_text("%s"%framerate)
253 else :
254 self.logging.debug('Something goes wrong')
255 self.webcam_widdget_table_position = row
238256
239 self.webcam_widgets[key] = widget # save the widget257 self.webcam_widgets[key] = widget # save the widgetyy
240 258
241 widget.show()259 widget.show()
242 table.attach(widget, 1, 2, row, row+1,xpadding = 10 )260 table.attach(widget, 1, 2, row, row+1,xpadding = 10 )
@@ -334,9 +352,79 @@
334 for (w_key, w_widget) in self.webcam_widgets.iteritems() :352 for (w_key, w_widget) in self.webcam_widgets.iteritems() :
335 # Sepcific operation for framerate_list widget353 # Sepcific operation for framerate_list widget
336 if w_key == 'framerate_list' :354 if w_key == 'framerate_list' :
337 w_widget.refresh(project_data['webcam_data']['framerate_list'],355 # 2 cases only one framerate or several framerates :
338 project_data['webcam_data']['framerate_selected'] )356 # display a Label or a Scale
357
358 # current widget is a label
359 if type(w_widget) == gtk.Label :
360 # how many framerates in framerate list
361 if len( project_data['webcam_data']['framerate_list'] ) > 1 :
362 # Sevaral framerates
363 # Hide current widget
364 w_widget.hide()
365 # create a Framerate_scale widget
366 widget = Framerate_scale(project_data['webcam_data']['framerate_list'],
367 project_data['webcam_data']['framerate_selected'],
368 self._cb_framerate_selected)
369
370
371 # Parent is a table attach new widget
372 w_widget.parent.attach( widget, 1, 2,
373 self.webcam_widdget_table_position,
374 self.webcam_widdget_table_position+1,
375 xpadding = 10 )
376
377 self.webcam_widgets[w_key] = widget # replace the widget
378
379 elif len( project_data['webcam_data']['framerate_list'] ) == 1 :
380 # only one framerate update label
381 w_text = int( project_data['webcam_data']['framerate_selected'][0] /
382 project_data['webcam_data']['framerate_selected'][1])
383 w_text ="%s"%w_text
384 w_widget.set_text(w_text)
385 else :
386 # Not normal
387 lerr = " 0 is an invalid number of framerates."
388 raise LEXCEP.LucioException, lerr
389
390 # current widegt is a framerate scale
391 else :
392 # how many framerates in framerate list
393 if len( project_data['webcam_data']['framerate_list'] ) > 1 :
394 # Several framerates
395 # refresh Framerate_scale widget
396
397 w_widget.refresh(project_data['webcam_data']['framerate_list'],
398 project_data['webcam_data']['framerate_selected'] )
399
400 elif len( project_data['webcam_data']['framerate_list'] ) == 1 :
401 # only one framerate is available
402 # Hide current widget
403 w_widget.hide()
404
405 # create a Label widget
406 widget = gtk.Label()
407 widget.set_alignment(xalign = 0.0, yalign = 0.5) # left justification
408 w_text = int( project_data['webcam_data']['framerate_selected'][0]/
409 project_data['webcam_data']['framerate_selected'][1])
410 w_text ="%s"%w_text
411 widget.set_text("%s"%framerate)
412
413 # Parent is a table attach new widget
414 w_widget.parent.attach( widget, 1, 2,
415 self.webcam_widdget_table_position,
416 self.webcam_widdget_table_position+1,
417 xpadding = 10 )
418
419 self.webcam_widgets[w_key] = widget # replace the widget
420 else :
421 # Not normal
422 lerr = " 0 is an invalid number of framerates."
423 raise LEXCEP.LucioException, lerr
424
339 self._framerate_list = project_data['webcam_data']['framerate_list']425 self._framerate_list = project_data['webcam_data']['framerate_list']
426 self._framerate_selected = project_data['webcam_data']['framerate_selected']
427
340 # for other webcam widgets : only text to update428 # for other webcam widgets : only text to update
341 else :429 else :
342 if project_data['webcam_data'].has_key(w_key) : 430 if project_data['webcam_data'].has_key(w_key) :

Subscribers

People subscribed via source and target branches

to all changes: