Code review comment for lp:~niclasl/pantheon-terminal/fix-1218681

I agree that saving the actual terminal and not only the directory would be more useful, but if I'm going to save the TerminalWidget object when a tab is closed, shouldn't there be a maximum number of stored objects, e.g. 10 last closed? If not, then hidden terminal widgets and bash processes would keep accumulating while the window is kept open. If it is limited, the same limit would need to be added to DynamicNotebook so that it doesn't store unlimited number of tabs.

The problem with the tab that gets added to the first window's trash bin even though it was closed in the second window seems to be related to DynamicNotebook as well. When the tab is moved from window A to window B, the signal handlers that the notebook in window A added to the tab are kept alongside the new handlers added by the notebook in window B. When the tab is closed, the connected signals from both window A and B are activated and therefore the tab ends up in window A's trash bin.

So how should I proceed with this? It looks like this cannot be fixed (in a nice way) without also touching DynamicNotebook.