Code review comment for lp:~niclasl/midori/granite-fixes

Revision history for this message
Niclas Lockner (niclasl) wrote :

"The first two hunks should just be without the #if."

Done. Now the label is always center-aligned, and the dynamic-notebook class is always added.

"I've changed the icon in the elementary theme so that we can stick to "tab-new-symbolic". This doesn't need an if."

if removed.

"Also, Gtk.Notebook now draws a background behind the tabbar and eGtk has been updated for this. So I think we can remove code that was intended to duplicate that feature of Dynamic Notebook."

Great! I removed the render_activity call.

The branch is now ready for another review.

« Back to merge proposal