Code review comment for lp:~nickpapior/siesta/trunk-kpoint-dos

Revision history for this message
Alberto Garcia (albertog) wrote :

Hi Nick,

As a compromise, I have written the following (attached) for the dos section of the manual.
If you like it, please go ahead and merge the branch in the trunk.

  Best regards,

   Alberto

> On 28 Jun 2018, at 08:37, Nick Papior <email address hidden> wrote:
>
> Would it suffice to add a line:
>
> "Note that DOS.kgrid.? does not influence the k-points in the EIG file, i.e. kgrid.? determines the sampled eigenvalues in the EIG file."
>
> It is more that later it *could* be nice to create the EIG file based on the DOS.kgrid?
>
> If you don't agree I can comment it out so it is easy to add later?
> --
> https://code.launchpad.net/~nickpapior/siesta/trunk-kpoint-dos/+merge/348522
> You are requested to review the proposed merge of lp:~nickpapior/siesta/trunk-kpoint-dos into lp:siesta.

« Back to merge proposal