Code review comment for lp:~nickpapior/siesta/trunk-k-file

Revision history for this message
Nick Papior (nickpapior) wrote :

Thanks for the comments!

I have just amended a fix for your comments.

As for your suggestion 2 it requires the epsilon(k) to be rotational invariant such that one can be sure that all irreducible wedges (for any crystal) will yield the correct result. Or, did you have something else in mind?

« Back to merge proposal