Merge lp:~nickpapior/siesta/4.1-cml into lp:~albertog/siesta/4.1-cml

Proposed by Nick Papior
Status: Merged
Approved by: Alberto Garcia
Approved revision: 600
Merged at revision: 601
Proposed branch: lp:~nickpapior/siesta/4.1-cml
Merge into: lp:~albertog/siesta/4.1-cml
Diff against target: 129 lines (+10/-15)
8 files modified
NOTICE.txt (+0/-3)
Obj/DOCUMENTED-TEMPLATE.make (+1/-1)
Src/wxml/m_wxml_core.f90 (+3/-3)
Src/wxml/m_wxml_elstack.f90 (+1/-1)
Util/CMLComp/ccViz (+2/-2)
Util/SiestaSubroutine/ProtoNEB/Src/Makefile (+1/-2)
Util/SiestaSubroutine/SimpleTest/Src/Makefile (+1/-2)
version.info (+1/-1)
To merge this branch: bzr merge lp:~nickpapior/siesta/4.1-cml
Reviewer Review Type Date Requested Status
Alberto Garcia Approve
Review via email: mp+308962@code.launchpad.net

Description of the change

Fixed some minor things and updated last references to FoX in makefile and NOTICE.txt

To post a comment you must log in.
Revision history for this message
Alberto Garcia (albertog) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NOTICE.txt'
--- NOTICE.txt 2016-05-27 15:20:03 +0000
+++ NOTICE.txt 2016-10-20 19:44:57 +0000
@@ -5,9 +5,6 @@
5different licensing terms, so see below. Other accompanying products5different licensing terms, so see below. Other accompanying products
6without special requirements are not listed.6without special requirements are not listed.
77
8This package includes a copy of the FoX software, which has its own
9license, copyright, and attribution terms. (See Src/FoX)
10
11This package includes a copy of the SiestaXC library, which has its own8This package includes a copy of the SiestaXC library, which has its own
12license, copyright, and attribution terms. (See Src/SiestaXC)9license, copyright, and attribution terms. (See Src/SiestaXC)
1310
1411
=== modified file 'Obj/DOCUMENTED-TEMPLATE.make'
--- Obj/DOCUMENTED-TEMPLATE.make 2016-10-04 09:22:48 +0000
+++ Obj/DOCUMENTED-TEMPLATE.make 2016-10-20 19:44:57 +0000
@@ -40,7 +40,7 @@
4040
41# The FC_SERIAL symbol is useful in at least two cases:41# The FC_SERIAL symbol is useful in at least two cases:
42# 1. When the "MPI compiler environment" is so complex that it might42# 1. When the "MPI compiler environment" is so complex that it might
43# trick the configure scripts (for FoX at least).43# trick the configure scripts.
44# 2. When executables compiled with a (parallel) FC are flagged by 44# 2. When executables compiled with a (parallel) FC are flagged by
45# the computer centers as "queuing-system-only". 45# the computer centers as "queuing-system-only".
46# Most utilities are thus compiled with FC_SERIAL, which in practice46# Most utilities are thus compiled with FC_SERIAL, which in practice
4747
=== modified file 'Src/wxml/m_wxml_core.f90'
--- Src/wxml/m_wxml_core.f90 2009-08-11 10:19:43 +0000
+++ Src/wxml/m_wxml_core.f90 2016-10-20 19:44:57 +0000
@@ -285,7 +285,7 @@
285type(xmlf_t), intent(inout) :: xf285type(xmlf_t), intent(inout) :: xf
286character(len=*), intent(in) :: name286character(len=*), intent(in) :: name
287287
288character(len=100) :: current288character(len=2000) :: current
289289
290if (is_empty(xf%stack)) then290if (is_empty(xf%stack)) then
291 call wxml_fatal(xf, "Out of elements to close")291 call wxml_fatal(xf, "Out of elements to close")
@@ -312,7 +312,7 @@
312subroutine xml_Close(xf)312subroutine xml_Close(xf)
313type(xmlf_t), intent(inout) :: xf313type(xmlf_t), intent(inout) :: xf
314314
315character(len=200) :: name315character(len=2000) :: name
316316
317do317do
318 if (is_empty(xf%stack)) exit318 if (is_empty(xf%stack)) exit
@@ -407,7 +407,7 @@
407type(xmlf_t), intent(inout) :: xf407type(xmlf_t), intent(inout) :: xf
408408
409integer :: i, status, size, key_len, value_len409integer :: i, status, size, key_len, value_len
410character(len=200) :: key, value410character(len=2000) :: key, value
411411
412do i = 1, len(xf%dict)412do i = 1, len(xf%dict)
413 call get_key(xf%dict,i,key,key_len,status)413 call get_key(xf%dict,i,key,key_len,status)
414414
=== modified file 'Src/wxml/m_wxml_elstack.f90'
--- Src/wxml/m_wxml_elstack.f90 2009-08-06 15:05:23 +0000
+++ Src/wxml/m_wxml_elstack.f90 2016-10-20 19:44:57 +0000
@@ -15,7 +15,7 @@
15real, parameter, private :: STACK_SIZE_MULT = 1.515real, parameter, private :: STACK_SIZE_MULT = 1.5
1616
17type, private :: elstack_item17type, private :: elstack_item
18 character(len=100) :: data18 character(len=200) :: data
19end type19end type
2020
21type, public :: elstack_t21type, public :: elstack_t
2222
=== modified file 'Util/CMLComp/ccViz'
--- Util/CMLComp/ccViz 2009-06-24 14:49:27 +0000
+++ Util/CMLComp/ccViz 2016-10-20 19:44:57 +0000
@@ -3681,7 +3681,7 @@
36813681
3682 <!-- The parameter value *should* be in a scalar/array/matrix child.3682 <!-- The parameter value *should* be in a scalar/array/matrix child.
3683 Sometimes it is in the value attribute though, so we check below3683 Sometimes it is in the value attribute though, so we check below
3684 That option will be removed later on since FoX never does that. -->3684 -->
36853685
3686 <td class="paramvalue">3686 <td class="paramvalue">
3687 <xsl:choose>3687 <xsl:choose>
@@ -8736,7 +8736,7 @@
8736 <golem:seealso>gwtsystem</golem:seealso>8736 <golem:seealso>gwtsystem</golem:seealso>
8737 </entry>8737 </entry>
87388738
8739 <entry id="atomArray" term="FoX Atom array parser">8739 <entry id="atomArray" term="Atom array parser">
8740 <annotation />8740 <annotation />
8741 <definition />8741 <definition />
8742 <description />8742 <description />
87438743
=== modified file 'Util/SiestaSubroutine/ProtoNEB/Src/Makefile'
--- Util/SiestaSubroutine/ProtoNEB/Src/Makefile 2016-01-25 16:00:16 +0000
+++ Util/SiestaSubroutine/ProtoNEB/Src/Makefile 2016-10-20 19:44:57 +0000
@@ -38,9 +38,8 @@
38FDF=libfdf.a38FDF=libfdf.a
39XMLPARSER=libxmlparser.a39XMLPARSER=libxmlparser.a
40XC=libSiestaXC.a40XC=libSiestaXC.a
41FoX_LIBS=`$(OBJ_DIR)/FoX/FoX-config --libs --wcml`
42ALL_LIBS= $(SIESTA_LIB) $(FDF) $(WXML) $(XMLPARSER) $(XC) \41ALL_LIBS= $(SIESTA_LIB) $(FDF) $(WXML) $(XMLPARSER) $(XC) \
43 $(MPI_INTERFACE) $(COMP_LIBS) $(FoX_LIBS) $(LIBS)42 $(MPI_INTERFACE) $(COMP_LIBS) $(LIBS)
44#43#
45libs_collected:44libs_collected:
46 (cd $(OBJ_DIR) ; \45 (cd $(OBJ_DIR) ; \
4746
=== modified file 'Util/SiestaSubroutine/SimpleTest/Src/Makefile'
--- Util/SiestaSubroutine/SimpleTest/Src/Makefile 2016-01-25 16:00:16 +0000
+++ Util/SiestaSubroutine/SimpleTest/Src/Makefile 2016-10-20 19:44:57 +0000
@@ -52,9 +52,8 @@
52FDF=libfdf.a52FDF=libfdf.a
53XMLPARSER=libxmlparser.a53XMLPARSER=libxmlparser.a
54XC=libSiestaXC.a54XC=libSiestaXC.a
55FoX_LIBS=`$(OBJ_DIR)/FoX/FoX-config --libs --wcml`
56ALL_LIBS= $(SIESTA_LIB) $(FDF) $(WXML) $(XMLPARSER) $(XC) \55ALL_LIBS= $(SIESTA_LIB) $(FDF) $(WXML) $(XMLPARSER) $(XC) \
57 $(MPI_INTERFACE) $(COMP_LIBS) $(FoX_LIBS) $(LIBS)56 $(MPI_INTERFACE) $(COMP_LIBS) $(LIBS)
58#57#
59libs_collected:58libs_collected:
60 (cd $(OBJ_DIR) ; \59 (cd $(OBJ_DIR) ; \
6160
=== modified file 'version.info'
--- version.info 2016-10-19 07:39:07 +0000
+++ version.info 2016-10-20 19:44:57 +0000
@@ -1,1 +1,1 @@
1siesta-4.1--5941siesta-4.1--594-np-cml-1

Subscribers

People subscribed via source and target branches

to all changes: