Merge lp:~nickpapior/siesta/4.1-cml into lp:~albertog/siesta/4.1-cml

Proposed by Nick Papior
Status: Merged
Approved by: Alberto Garcia
Approved revision: 600
Merged at revision: 601
Proposed branch: lp:~nickpapior/siesta/4.1-cml
Merge into: lp:~albertog/siesta/4.1-cml
Diff against target: 129 lines (+10/-15)
8 files modified
NOTICE.txt (+0/-3)
Obj/DOCUMENTED-TEMPLATE.make (+1/-1)
Src/wxml/m_wxml_core.f90 (+3/-3)
Src/wxml/m_wxml_elstack.f90 (+1/-1)
Util/CMLComp/ccViz (+2/-2)
Util/SiestaSubroutine/ProtoNEB/Src/Makefile (+1/-2)
Util/SiestaSubroutine/SimpleTest/Src/Makefile (+1/-2)
version.info (+1/-1)
To merge this branch: bzr merge lp:~nickpapior/siesta/4.1-cml
Reviewer Review Type Date Requested Status
Alberto Garcia Approve
Review via email: mp+308962@code.launchpad.net

Description of the change

Fixed some minor things and updated last references to FoX in makefile and NOTICE.txt

To post a comment you must log in.
Revision history for this message
Alberto Garcia (albertog) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NOTICE.txt'
2--- NOTICE.txt 2016-05-27 15:20:03 +0000
3+++ NOTICE.txt 2016-10-20 19:44:57 +0000
4@@ -5,9 +5,6 @@
5 different licensing terms, so see below. Other accompanying products
6 without special requirements are not listed.
7
8-This package includes a copy of the FoX software, which has its own
9-license, copyright, and attribution terms. (See Src/FoX)
10-
11 This package includes a copy of the SiestaXC library, which has its own
12 license, copyright, and attribution terms. (See Src/SiestaXC)
13
14
15=== modified file 'Obj/DOCUMENTED-TEMPLATE.make'
16--- Obj/DOCUMENTED-TEMPLATE.make 2016-10-04 09:22:48 +0000
17+++ Obj/DOCUMENTED-TEMPLATE.make 2016-10-20 19:44:57 +0000
18@@ -40,7 +40,7 @@
19
20 # The FC_SERIAL symbol is useful in at least two cases:
21 # 1. When the "MPI compiler environment" is so complex that it might
22-# trick the configure scripts (for FoX at least).
23+# trick the configure scripts.
24 # 2. When executables compiled with a (parallel) FC are flagged by
25 # the computer centers as "queuing-system-only".
26 # Most utilities are thus compiled with FC_SERIAL, which in practice
27
28=== modified file 'Src/wxml/m_wxml_core.f90'
29--- Src/wxml/m_wxml_core.f90 2009-08-11 10:19:43 +0000
30+++ Src/wxml/m_wxml_core.f90 2016-10-20 19:44:57 +0000
31@@ -285,7 +285,7 @@
32 type(xmlf_t), intent(inout) :: xf
33 character(len=*), intent(in) :: name
34
35-character(len=100) :: current
36+character(len=2000) :: current
37
38 if (is_empty(xf%stack)) then
39 call wxml_fatal(xf, "Out of elements to close")
40@@ -312,7 +312,7 @@
41 subroutine xml_Close(xf)
42 type(xmlf_t), intent(inout) :: xf
43
44-character(len=200) :: name
45+character(len=2000) :: name
46
47 do
48 if (is_empty(xf%stack)) exit
49@@ -407,7 +407,7 @@
50 type(xmlf_t), intent(inout) :: xf
51
52 integer :: i, status, size, key_len, value_len
53-character(len=200) :: key, value
54+character(len=2000) :: key, value
55
56 do i = 1, len(xf%dict)
57 call get_key(xf%dict,i,key,key_len,status)
58
59=== modified file 'Src/wxml/m_wxml_elstack.f90'
60--- Src/wxml/m_wxml_elstack.f90 2009-08-06 15:05:23 +0000
61+++ Src/wxml/m_wxml_elstack.f90 2016-10-20 19:44:57 +0000
62@@ -15,7 +15,7 @@
63 real, parameter, private :: STACK_SIZE_MULT = 1.5
64
65 type, private :: elstack_item
66- character(len=100) :: data
67+ character(len=200) :: data
68 end type
69
70 type, public :: elstack_t
71
72=== modified file 'Util/CMLComp/ccViz'
73--- Util/CMLComp/ccViz 2009-06-24 14:49:27 +0000
74+++ Util/CMLComp/ccViz 2016-10-20 19:44:57 +0000
75@@ -3681,7 +3681,7 @@
76
77 <!-- The parameter value *should* be in a scalar/array/matrix child.
78 Sometimes it is in the value attribute though, so we check below
79- That option will be removed later on since FoX never does that. -->
80+ -->
81
82 <td class="paramvalue">
83 <xsl:choose>
84@@ -8736,7 +8736,7 @@
85 <golem:seealso>gwtsystem</golem:seealso>
86 </entry>
87
88- <entry id="atomArray" term="FoX Atom array parser">
89+ <entry id="atomArray" term="Atom array parser">
90 <annotation />
91 <definition />
92 <description />
93
94=== modified file 'Util/SiestaSubroutine/ProtoNEB/Src/Makefile'
95--- Util/SiestaSubroutine/ProtoNEB/Src/Makefile 2016-01-25 16:00:16 +0000
96+++ Util/SiestaSubroutine/ProtoNEB/Src/Makefile 2016-10-20 19:44:57 +0000
97@@ -38,9 +38,8 @@
98 FDF=libfdf.a
99 XMLPARSER=libxmlparser.a
100 XC=libSiestaXC.a
101-FoX_LIBS=`$(OBJ_DIR)/FoX/FoX-config --libs --wcml`
102 ALL_LIBS= $(SIESTA_LIB) $(FDF) $(WXML) $(XMLPARSER) $(XC) \
103- $(MPI_INTERFACE) $(COMP_LIBS) $(FoX_LIBS) $(LIBS)
104+ $(MPI_INTERFACE) $(COMP_LIBS) $(LIBS)
105 #
106 libs_collected:
107 (cd $(OBJ_DIR) ; \
108
109=== modified file 'Util/SiestaSubroutine/SimpleTest/Src/Makefile'
110--- Util/SiestaSubroutine/SimpleTest/Src/Makefile 2016-01-25 16:00:16 +0000
111+++ Util/SiestaSubroutine/SimpleTest/Src/Makefile 2016-10-20 19:44:57 +0000
112@@ -52,9 +52,8 @@
113 FDF=libfdf.a
114 XMLPARSER=libxmlparser.a
115 XC=libSiestaXC.a
116-FoX_LIBS=`$(OBJ_DIR)/FoX/FoX-config --libs --wcml`
117 ALL_LIBS= $(SIESTA_LIB) $(FDF) $(WXML) $(XMLPARSER) $(XC) \
118- $(MPI_INTERFACE) $(COMP_LIBS) $(FoX_LIBS) $(LIBS)
119+ $(MPI_INTERFACE) $(COMP_LIBS) $(LIBS)
120 #
121 libs_collected:
122 (cd $(OBJ_DIR) ; \
123
124=== modified file 'version.info'
125--- version.info 2016-10-19 07:39:07 +0000
126+++ version.info 2016-10-20 19:44:57 +0000
127@@ -1,1 +1,1 @@
128-siesta-4.1--594
129+siesta-4.1--594-np-cml-1

Subscribers

People subscribed via source and target branches

to all changes: