Code review comment for lp:~nick-schutt/lava-dispatcher/nicks-highbank-support

Revision history for this message
Nicholas Schutt (nick-schutt) wrote :

> I'm not sure we want to drop the sudo there. Even though the dispatcher
> currently requires being run as root, I think in the long run we should
> be able to drop that requirement. Also, if we are root already, the sudo
> does no harm.

Antonio,

I will undo the sudo changes since they're not important now that everything works with the scheduler. But, I saw an issue when running the dispatcher as root in my own local virtual environment. For each sudo command the virtual environment was lost; I'm not sure why.

Nick

« Back to merge proposal