Unity 8

Code review comment for lp:~nick-dedekind/unity8/side-stage-redesign

  1. side-stage-redesign
  2. Merge into trunk
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

It's getting there...

In TouchGestureArea.cpp:

If you insist in watching touches you already own (as in QQuickWindow already sends updates to you), would it be possible to at least updateTouchPoints() only once per QTouchEvent? As opposed to in both touchEvent() and unownedTouchEvent()?

Also I think it's important to have a comment in the code (probably a TODO or FIXME) explaining why the heck do we watch touch points we already own. It doesn't make sense unless you're working around some issue. Eventually this issue should be properly understood.

review: Needs Information

« Back to merge proposal