Code review comment for lp:~nick-dedekind/unity8/lp1328646
Revision history for this message
| Nick Dedekind (nick-dedekind) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
> I really hate the ref/deref happening on QML side, could we use QML ownership
> to do this?
I think I've addressed all your concerns. Was able to move the model instantiation into the cache now that i've fixed up the QMenuModel mocking.
The GC looks a bit hairy in the qmltests for testing the deletion, but it seems to work.