Code review comment for lp:~nick-dedekind/unity8/indicator.multi-icon

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> 0.7 grid units seems a weird number. In theory we're told to never use decimal
> grid units, but i don't mind using 0.5 as you do somewhere else since
> \li Most laptops
> \li 1 gu = 8 px
>
> \li Retina laptops
> \li 1 gu = 16 px
>
> \li Phone with 4 inch screen at HD resolution (around 720x1,280 pixels)
> \li 1 gu = 18 px
>
> \li Tablet with 10 inch screen at HD resolution (around 720x1,280
> pixels)
> \li 1 gu = 10 px
>
> So 0.5 gu will 99.99% still be an exact number of pixels, but 0.7gu mean 5.6,
> 10.2, 12.6 and 7 pixels respectively, which is a bit weird to declare that we
> want something to be 5.6 pixels width
>
> So, the question is: Why 0.7?

Respaced to 0.5 gu.

« Back to merge proposal