Merge lp:~nick-dedekind/unity/smart-scopes.dash-focus into lp:~unity-team/unity/libunity-7.0-breakage

Proposed by Nick Dedekind
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3101
Proposed branch: lp:~nick-dedekind/unity/smart-scopes.dash-focus
Merge into: lp:~unity-team/unity/libunity-7.0-breakage
Diff against target: 45 lines (+0/-19)
2 files modified
dash/DashView.cpp (+0/-17)
dash/DashView.h (+0/-2)
To merge this branch: bzr merge lp:~nick-dedekind/unity/smart-scopes.dash-focus
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+155308@code.launchpad.net

Commit message

Now matches unity trunk dash focus mechanism.

Description of the change

Now matches unity trunk dash focus mechanism.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'dash/DashView.cpp'
--- dash/DashView.cpp 2013-03-22 21:28:35 +0000
+++ dash/DashView.cpp 2013-03-25 17:51:21 +0000
@@ -1284,8 +1284,6 @@
1284 search_bar_->can_refine_search = can_refine_search;1284 search_bar_->can_refine_search = can_refine_search;
1285 });1285 });
12861286
1287 nux::GetWindowCompositor().SetKeyFocusArea(default_focus());
1288
1289 view->QueueDraw();1287 view->QueueDraw();
1290 QueueDraw();1288 QueueDraw();
1291}1289}
@@ -1647,20 +1645,5 @@
1647 return content_geo_;1645 return content_geo_;
1648}1646}
16491647
1650bool DashView::SetParentObject(Area *parent)
1651{
1652 //This is a bit crap and should be fixed in nux.
1653 //If you reparent, you need to fix up the focus tree.
1654 if (View::SetParentObject(parent))
1655 {
1656 // Because the scopes are now created synchronously on construction, we wont be parented by the time the focus is updated.
1657 InputArea* area = nux::GetWindowCompositor().GetKeyFocusArea();
1658 if (area)
1659 area->SetPathToKeyFocusArea();
1660 return true;
1661 }
1662 return false;
1663}
1664
1665}1648}
1666}1649}
16671650
=== modified file 'dash/DashView.h'
--- dash/DashView.h 2013-03-22 12:44:53 +0000
+++ dash/DashView.h 2013-03-25 17:51:21 +0000
@@ -75,8 +75,6 @@
7575
76 nux::Geometry const& GetContentGeometry() const;76 nux::Geometry const& GetContentGeometry() const;
7777
78 virtual bool SetParentObject(Area *parent);
79
80protected:78protected:
81 void ProcessDndEnter();79 void ProcessDndEnter();
8280

Subscribers

People subscribed via source and target branches

to all changes: