Code review comment for lp:~nick-dedekind/unity/preview.lp1043997-music-tracks

Revision history for this message
Michal Hruby (mhr3) wrote :

> Looks good code wise. Though the only problem I see is when you re-open the
> dash the music stops playing. I would think it would continue to play
> independent of the dash opening/closing. Though im not sure how easy of a fix
> that will be...if it is large enough we should merge this part, then open a
> new bug to work that part. Let me know what you think!

According to design the preview needs to stop right away after closing dash, but that's tracked as #1045298. Approving.

review: Approve

« Back to merge proposal