Code review comment for lp:~nick-dedekind/unity/lp923657.dash-dismiss

Revision history for this message
Christopher Lee (veebers) wrote :

Reviewing the AP test, instead of thomi :)
I'm informed that the merge conflict is being fixed up already.

A couple of minor things:
202 + prev_monitor = None
  - Never actually used
203 + .. range(0, self...
  - The 0 isn't required, start defaults to 0
204 +
  - Extra newline
206 + self.dash.ensure_visible()
  - Please also add self.addCleanup(self.dash.ensure_hidden) to make sure things are cleaned up in case of any issues.

Otherwise looks good.

« Back to merge proposal