Code review comment for lp:~nick-dedekind/unity/lp1039020.preview-text-escape

Revision history for this message
Andrea Azzarone (azzar1) wrote :

+ std::string tmp_text = escape_text ? GetEscapedText(text) : text;

You can do:

std::string tmp_text = escape_text ? GetEscapedText(text) : std::move(text);

But using the gcc implementation of std::string coping and moving are equivalent.

review: Approve

« Back to merge proposal