Code review comment for lp:~nick-dedekind/unity-api/shell_chrome

Revision history for this message
Gerry Boland (gerboland) wrote :

Ok. Will accept this is a client to server hint.

But please add more documentation to indicate the expected consequence in the shell of a client setting this.

Now I need to ask about how it will behave (this being as good a place as any to bring up these points):

1. does this only impact a Windowed surface? i.e. what does NormalChrome mode mean for a fullscreen surface? what does LowChrome mean for VerticallyMaximised?

2. I, as a client, ask for a Windowed surface with LowChrome. On phone, this will end up being a fullscreen surface, but windowed on desktop. Do I, as a client, know that I'm fullscreen on the phone? Or do I think I'm windowed? i.e. does shell actually inform the client of the dynamically chosen surface state it has chosen?

review: Needs Information

« Back to merge proposal