Merge lp:~nick-dedekind/unity-api/multi-monitor into lp:unity-api

Proposed by Michael Zanetti
Status: Needs review
Proposed branch: lp:~nick-dedekind/unity-api/multi-monitor
Merge into: lp:unity-api
Diff against target: 93 lines (+20/-26)
4 files modified
debian/changelog (+7/-0)
include/unity/shell/application/CMakeLists.txt (+3/-0)
include/unity/shell/application/MirMousePointerInterface.h (+2/-23)
include/unity/shell/application/MirPlatformCursor.h (+8/-3)
To merge this branch: bzr merge lp:~nick-dedekind/unity-api/multi-monitor
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Unity Team Pending
Review via email: mp+314837@code.launchpad.net

Commit message

API requirements for multiple screen support

Description of the change

Added register/unregisterMMouseCursors so that mouse cursor will not be overwritten during fleeting states when creating windows secondary screens.

related branches:
https://code.launchpad.net/~nick-dedekind/unity8/multi-monitor/+merge/314835
https://code.launchpad.net/~nick-dedekind/qtmir/multi-monitor/+merge/314836

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:250
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/150/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4366
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4394
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4227
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4227/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4227
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4227/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4227
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4227/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4227
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4227/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4227
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4227/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4227
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4227/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/150/rebuild

review: Approve (continuous-integration)
251. By Nick Dedekind

merged with trunk

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:251
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/163/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4662
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4690
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4513
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4513/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4513
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4513/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4513
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4513/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4513
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4513/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4513
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4513/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4513
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4513/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/163/rebuild

review: Approve (continuous-integration)
252. By Nick Dedekind

bump

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:252
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/177/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4897
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4925
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4733
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4733/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4733
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4733/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4733
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4733/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4733
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4733/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4733
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4733/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4733
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4733/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/177/rebuild

review: Approve (continuous-integration)

Unmerged revisions

252. By Nick Dedekind

bump

251. By Nick Dedekind

merged with trunk

250. By Nick Dedekind

fixed changelog

249. By Nick Dedekind

merged trunk

248. By Nick Dedekind

merged parent

247. By Nick Dedekind

version bump

246. By Nick Dedekind

merged with trunk

245. By Nick Dedekind

merged with parent

244. By Nick Dedekind

updated cursor interface

243. By Nick Dedekind

merged with trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2017-03-17 11:08:20 +0000
+++ debian/changelog 2017-04-05 11:26:31 +0000
@@ -1,3 +1,10 @@
1unity-api (8.7ubuntu2) UNRELEASED; urgency=medium
2
3 [ Nick Dedekind ]
4 * MirPlatformCursor - updates for multi-screen.
5
6 -- Nick Dedekind <nick.dedekind@canonical.com> Wed, 05 Apr 2017 12:26:08 +0100
7
1unity-api (8.6+17.04.20170317-0ubuntu1) zesty; urgency=medium8unity-api (8.6+17.04.20170317-0ubuntu1) zesty; urgency=medium
29
3 [ Michael Zanetti ]10 [ Michael Zanetti ]
411
=== modified file 'include/unity/shell/application/CMakeLists.txt'
--- include/unity/shell/application/CMakeLists.txt 2017-03-17 11:07:57 +0000
+++ include/unity/shell/application/CMakeLists.txt 2017-04-05 11:26:31 +0000
@@ -3,6 +3,9 @@
3file(GLOB headers "${CMAKE_CURRENT_SOURCE_DIR}/*.h")3file(GLOB headers "${CMAKE_CURRENT_SOURCE_DIR}/*.h")
4file(GLOB internal_headers "${CMAKE_CURRENT_SOURCE_DIR}/internal/*.h")4file(GLOB internal_headers "${CMAKE_CURRENT_SOURCE_DIR}/internal/*.h")
55
6add_custom_target(appheaders
7 SOURCES ${headers} ${internal_headers})
8
6install(FILES ${headers} DESTINATION ${INCLUDE_INSTALL_DIR})9install(FILES ${headers} DESTINATION ${INCLUDE_INSTALL_DIR})
710
8set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)11set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
912
=== modified file 'include/unity/shell/application/MirMousePointerInterface.h'
--- include/unity/shell/application/MirMousePointerInterface.h 2016-05-18 20:51:23 +0000
+++ include/unity/shell/application/MirMousePointerInterface.h 2017-04-05 11:26:31 +0000
@@ -54,6 +54,8 @@
5454
55 virtual void setThemeName(const QString &themeName) = 0;55 virtual void setThemeName(const QString &themeName) = 0;
56 virtual QString themeName() const = 0;56 virtual QString themeName() const = 0;
57
58 virtual void moveTo(const QPoint& position) = 0;
57 /// @endcond59 /// @endcond
5860
59 /**61 /**
@@ -70,29 +72,6 @@
70 void cursorNameChanged(QString name);72 void cursorNameChanged(QString name);
71 void themeNameChanged(QString name);73 void themeNameChanged(QString name);
72 /// @endcond74 /// @endcond
73
74public Q_SLOTS:
75 /**
76 * @brief Handler for Mir mouse events
77 * The implementation should respond to Mir mouse events by moving itself along its parent
78 * area.
79 * This is called by Mir's platform cursor.
80 *
81 * Note that we get only relative mouse movement, since the mouse pointer position is defined
82 * by this very item. Ie., it's up to this class to decide whether or not it (the mouse pointer)
83 * should move (and how much) due to movement in a mouse device.
84 *
85 * @param movement Movement vector
86 */
87 virtual void handleMouseEvent(ulong timestamp, QPointF movement, Qt::MouseButtons buttons,
88 Qt::KeyboardModifiers modifiers) = 0;
89
90 /**
91 * @brief Handler for Mir mouse wheel events
92 * This is called by Mir's platform cursor.
93 */
94 virtual void handleWheelEvent(ulong timestamp, QPoint angleDelta, Qt::KeyboardModifiers modifiers) = 0;
95
96};75};
9776
98#endif // MIR_MOUSE_POINTER_INTERFACE_H77#endif // MIR_MOUSE_POINTER_INTERFACE_H
9978
=== modified file 'include/unity/shell/application/MirPlatformCursor.h'
--- include/unity/shell/application/MirPlatformCursor.h 2015-09-18 16:00:09 +0000
+++ include/unity/shell/application/MirPlatformCursor.h 2017-04-05 11:26:31 +0000
@@ -30,9 +30,14 @@
30{30{
31public:31public:
32 /**32 /**
33 * @brief Set the QML mouse pointer that this platform cursor will talk to33 * @brief Register a mouse pointer that this platform cursor will talk to
34 */34 */
35 virtual void setMousePointer(MirMousePointerInterface *mousePointer) = 0;35 virtual void registerMousePointer(MirMousePointerInterface *mousePointer) = 0;
36
37 /**
38 * @brief Unregister a mouse pointer that this platform cursor will talk to
39 */
40 virtual void unregisterMousePointer(MirMousePointerInterface *mousePointer) = 0;
36};41};
3742
38#endif // MIR_PLATFORM_CURSOR_H43#endif // MIR_PLATFORM_CURSOR_H

Subscribers

People subscribed via source and target branches

to all changes: