Code review comment for lp:~nick-dedekind/ubuntu-ui-toolkit/lp1378821.time-translation

Revision history for this message
Christian Dywan (kalikiana) wrote :

First and foremost, let's have an API proposal for this. Adding new API to the UITK means it will stay for a few years and if we just drop code like this we get in trouble (thumbnailer anyone?).

Second, we already have i18n for localization features. It seems to me like we'd want to extend that instead of a whole new component.

Third, how urgent is this? Who's using this aside from Unity? API should only be added to UITK if it's useful for several apps, otherwise there's little benefit and we still pay the cost of maintenance.

review: Needs Fixing

« Back to merge proposal