Code review comment for lp:~nick-dedekind/ubuntu-ui-toolkit/exclusiveGroup

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> There are few things to get sorted out still, the code looks good in general.
>
> We are also planning to move all our code to UbuntuToolkit library and
> UbuntuTookit NS (see https://code.launchpad.net/~zsombi/ubuntu-ui-
> toolkit/moveStyledItem/+merge/296802), hopefully lands soon so you can move
> your stuff under the lib.

I think I've addressed all the above and comments.
I've left the action::checked as a boolean rather than a tristate. On reflection, I believe that tristate should be handled in the implementer (ie Checkbox). Can't really get my head around tristate with Exclusive groups etc, as I don't think it makes much sense.
The mixed state doesn't really involve a "trigger", since it's not selectable.

Feel free to disagree :)

« Back to merge proposal