Code review comment for lp:~nick-dedekind/qtmir/prompt_sessions

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> +void getSurfaceDecendents(MirSurfaceItem* item, QList<MirSurfaceItem*>&
> surfaceChildren)
> am not a fan of returning the list via the argument. Why did you decide to do
> that? Why not just create & return a list?
>

Not the biggest fan either, but the method is recursive; and it's more efficient than concatenating lists together for each recursion.

« Back to merge proposal