This would do:
throw std::runtime_error(std::string("Incorrect EDID structure size:") + std::to_string(data.size()));
++ src/platforms/mirserver/miral/persist_display_config.cpp
since you remove the #if MIR_SERVER_VERSION block, please merge the list of mir headers so it is neater.
+++ src/platforms/mirserver/miral/persist_display_config.cpp
Nitpick: space after the "for":
+ for(auto iter = output.modes.cbegin(); iter != output.modes.cend(); ++iter, i++) {
+++ src/platforms/mirserver/qmirserver_p.cpp
Nitpick: please add "// namespace" after the anonymous namespace closing brace
+++ src/platforms/ mirserver/ miral/edid. cpp error(stringStr eam.str( ));
+ std::ostringstream stringStream;
+ stringStream << "Incorrect EDID structure size {" << data.size() << "}";
+ throw std::runtime_
This would do: error(std: :string( "Incorrect EDID structure size:") + std::to_ string( data.size( )));
throw std::runtime_
++ src/platforms/ mirserver/ miral/persist_ display_ config. cpp
since you remove the #if MIR_SERVER_VERSION block, please merge the list of mir headers so it is neater.
+++ src/platforms/ mirserver/ miral/persist_ display_ config. cpp modes.cbegin( ); iter != output. modes.cend( ); ++iter, i++) {
Nitpick: space after the "for":
+ for(auto iter = output.
+++ src/platforms/ mirserver/ qmirserver_ p.cpp
Nitpick: please add "// namespace" after the anonymous namespace closing brace
Rest looks good