Code review comment for lp:~nick-dedekind/qmenumodel/lp1385331.led

Revision history for this message
Albert Astals Cid (aacid) wrote :

After reading the code more i see my suggestion is not implementable without a big-ish rework (and maybe not at all) so i'll be happy enough if you add a comment to setActionStateParser saying that the class does not take ownership of actionStateParser

review: Needs Fixing

« Back to merge proposal