Code review comment for lp:~nick-dedekind/qmenumodel/lp1239394

Revision history for this message
Lars Karlitski (larsu) wrote :

g_sequence_get() never returns NULL, those checks are unnecessary.

g_sequence_get_iter_at_pos() always returns a valid iter, so e don't need the check for NULL.

Having the is_end_iter() check makes sense to me, but we should look for the actual cause of this crash: something is trying to access an invalid row name. Maybe we should even warn when that happens instead of silently failing?

review: Needs Fixing

« Back to merge proposal