Code review comment for lp:~nick-dedekind/qmenumodel/lp1199423
Revision history for this message
| Nick Dedekind (nick-dedekind) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> > > The changes look good to me, except for the ABI breakage in
> unitymenumodel.h
> > >
> > > Are we sure that all of its consumers are only using the QML plug-in?
> >
> > There are a few points where we used UnitMenuModel in it's C++ form, but
> only
> > as a pointer.
> > Nothing used the actionsChanged signal though.
>
> Okay, so what's the rule regarding known "okay" ABI breakages then? Is it okay
> to skip the ABI version bump in this case?
Is there an explicit ABI version? Or do you just mean bump to 0.2.8? If so, we can do that.